-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App Configuration provider: add telemetry schme #38933
Merged
ivywei0125
merged 8 commits into
Azure:feature/spring-boot-3
from
ivywei0125:yuwe/provider-schema-support
Mar 12, 2024
Merged
App Configuration provider: add telemetry schme #38933
ivywei0125
merged 8 commits into
Azure:feature/spring-boot-3
from
ivywei0125:yuwe/provider-schema-support
Mar 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivywei0125
requested review from
mrm9084,
chenrujun,
Netyyyy,
saragluna and
moarychan
as code owners
February 25, 2024 03:33
API change check API changes are not detected in this pull request. |
mrm9084
approved these changes
Mar 7, 2024
@@ -58,6 +62,10 @@ public class AppConfigurationFeatureManagementPropertySourceTest { | |||
|
|||
private static final String KEY_FILTER = "/foo/"; | |||
|
|||
private static final String TEST_E_TAG = "4f6dd610dd5e4deebc7fbaef685fb903"; | |||
|
|||
private static final String TEST_ENDPOINT = "https://test.azconfig.io"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: We have a TestConstants class with stuff like this in it.
saragluna
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Telemetry schema
Metadata is represented by a dictionary of string keys and string values. When telemetry is enabled, need to add
FeatureFlagId
,FeatureFlagReference
, andETag
. These 3 properties are agreed upon with Split.io used to trace feature flag.b64_url(SHA256(utf8_bytes(“${featureFlag.key}\n${featureFlag.label}”))).Replace('+', '-').Replace('/', '_').TrimEnd('=')
${endpoint}kv/${featureFlag.key}?label=${featureFlag.label}