Auto failover3 #38534
Merged
Auto failover3 #38534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
mrm9084
requested review from
chenrujun,
Netyyyy,
saragluna and
moarychan
as code owners
ivywei0125
reviewed
Feb 5, 2024
| try { | ||
| List<SRVRecord> srvRecords = findAutoFailoverEndpoints(mainEndpoint, providedEndpoints); | ||
|
|
||
| srvRecords.sort((SRVRecord a, SRVRecord b) -> a.compareTo(b)); |
There was a problem hiding this comment.
Do we need to sort this srvRecords? Is there no priority order for the user-defined endpoints array in yaml file?
If we sort this array, then it doesn't follow the order that user defined.
There was a problem hiding this comment.
This came up in the design review. We plan on supporting the SRV priority and weight values.
When a user defines multiple stores, we follow the list they provide, top down where the top option is the highest priority.
saragluna
approved these changes
Mar 13, 2024
...ring/cloud/appconfiguration/config/implementation/AppConfigurationReplicaClientsBuilder.java
Outdated
Show resolved
Hide resolved
...ring/cloud/appconfiguration/config/implementation/AppConfigurationReplicaClientsBuilder.java
Outdated
Show resolved
Hide resolved
...ring/cloud/appconfiguration/config/implementation/AppConfigurationReplicaClientsBuilder.java
Outdated
Show resolved
Hide resolved
...ring/cloud/appconfiguration/config/implementation/AppConfigurationReplicaClientsBuilder.java
Outdated
Show resolved
Hide resolved
…/java/com/azure/spring/cloud/appconfiguration/config/implementation/AppConfigurationReplicaClientsBuilder.java Co-authored-by: Xiaolu Dai <[email protected]>
…/java/com/azure/spring/cloud/appconfiguration/config/implementation/AppConfigurationReplicaClientsBuilder.java Co-authored-by: Xiaolu Dai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds Auto Failover to App Configuration. Looks up SRV records of configuration stores to find possible backup stores in case of provided stores are unreachable.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines