addChannelAcquisitionContextInCosmosDiagnosticsBasedOnLatency #38416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 22, 2024 14:37
xinlian12
requested review from
kushagraThapar,
FabianMeiswinkel,
kirankumarkolli,
milismsft,
aayush3011,
simorenoh,
jeet1995 and
Pilchie
as code owners
|
API change check API changes are not detected in this pull request. |
xinlian12
force-pushed
the
addChannelAcquisitionContextInCosmosDiagnosticsBasedOnThreshold
branch
from
b7ab5b0 to
c933c14
Compare
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
FabianMeiswinkel
pushed a commit
to FabianMeiswinkel/azure-sdk-for-java
that referenced
this pull request
Feb 3, 2024
…38416) * add channelAcquisitionContext in cosmosDiagnostics when reaching threshold --------- Co-authored-by: annie-mac <[email protected]>
FabianMeiswinkel
added a commit
that referenced
this pull request
Feb 4, 2024
* Few minor diagnostics perf improvements (#38232) * Check for actual meterRegistry * Update ClientTelemetryMetrics.java * Update ClientTelemetryMetrics.java * Update CosmosDiagnosticsTest.java * Removing String.format in metrics * Update ClientTelemetryMetrics.java * Update Uri.java * Update RntbdClientChannelHealthChecker.java * Update RntbdToken.java * Update FaultInjectionRequestContext.java * Update RntbdTokenStream.java * Update RntbdTokenStream.java * Update RntbdTokenStream.java * EnumMap changes * Avoiding ImmutableEnumMaps * Fixing unit tests * Update ClientTelemetryMetrics.java * Update FaultInjectionRequestContext.java * Update CHANGELOG.md * Release preparations * Update CHANGELOG.md * Allowing to opt-out of E2E timeout for non-point operations via system property or environment variable (#38388) * Allowing to opt-out of E2E timeout for non-point operations via system property or environment variable * Tests * Reacting to code review feedback * remove winutils download steps (#38030) Co-authored-by: annie-mac <[email protected]> * addChannelAcquisitionContextInCosmosDiagnosticsBasedOnLatency (#38416) * add channelAcquisitionContext in cosmosDiagnostics when reaching threshold --------- Co-authored-by: annie-mac <[email protected]> --------- Co-authored-by: Annie Liang <[email protected]> Co-authored-by: annie-mac <[email protected]>
FabianMeiswinkel
added a commit
that referenced
this pull request
Feb 4, 2024
* Few minor diagnostics perf improvements (#38232) * Check for actual meterRegistry * Update ClientTelemetryMetrics.java * Update ClientTelemetryMetrics.java * Update CosmosDiagnosticsTest.java * Removing String.format in metrics * Update ClientTelemetryMetrics.java * Update Uri.java * Update RntbdClientChannelHealthChecker.java * Update RntbdToken.java * Update FaultInjectionRequestContext.java * Update RntbdTokenStream.java * Update RntbdTokenStream.java * Update RntbdTokenStream.java * EnumMap changes * Avoiding ImmutableEnumMaps * Fixing unit tests * Update ClientTelemetryMetrics.java * Update FaultInjectionRequestContext.java * Update CHANGELOG.md * Release preparations * Update CHANGELOG.md * Allowing to opt-out of E2E timeout for non-point operations via system property or environment variable (#38388) * Allowing to opt-out of E2E timeout for non-point operations via system property or environment variable * Tests * Reacting to code review feedback * remove winutils download steps (#38030) Co-authored-by: annie-mac <[email protected]> * addChannelAcquisitionContextInCosmosDiagnosticsBasedOnLatency (#38416) * add channelAcquisitionContext in cosmosDiagnostics when reaching threshold --------- Co-authored-by: annie-mac <[email protected]> * Fixing release break for hotfix --------- Co-authored-by: Annie Liang <[email protected]> Co-authored-by: annie-mac <[email protected]>
FabianMeiswinkel
added a commit
that referenced
this pull request
Feb 4, 2024
* Few minor diagnostics perf improvements (#38232) * Check for actual meterRegistry * Update ClientTelemetryMetrics.java * Update ClientTelemetryMetrics.java * Update CosmosDiagnosticsTest.java * Removing String.format in metrics * Update ClientTelemetryMetrics.java * Update Uri.java * Update RntbdClientChannelHealthChecker.java * Update RntbdToken.java * Update FaultInjectionRequestContext.java * Update RntbdTokenStream.java * Update RntbdTokenStream.java * Update RntbdTokenStream.java * EnumMap changes * Avoiding ImmutableEnumMaps * Fixing unit tests * Update ClientTelemetryMetrics.java * Update FaultInjectionRequestContext.java * Update CHANGELOG.md * Release preparations * Update CHANGELOG.md * Allowing to opt-out of E2E timeout for non-point operations via system property or environment variable (#38388) * Allowing to opt-out of E2E timeout for non-point operations via system property or environment variable * Tests * Reacting to code review feedback * remove winutils download steps (#38030) Co-authored-by: annie-mac <[email protected]> * addChannelAcquisitionContextInCosmosDiagnosticsBasedOnLatency (#38416) * add channelAcquisitionContext in cosmosDiagnostics when reaching threshold --------- Co-authored-by: annie-mac <[email protected]> * Fixing release break for hotfix * Update utils.py --------- Co-authored-by: Annie Liang <[email protected]> Co-authored-by: annie-mac <[email protected]>
FabianMeiswinkel
added a commit
that referenced
this pull request
Feb 4, 2024
* Few minor diagnostics perf improvements (#38232) * Check for actual meterRegistry * Update ClientTelemetryMetrics.java * Update ClientTelemetryMetrics.java * Update CosmosDiagnosticsTest.java * Removing String.format in metrics * Update ClientTelemetryMetrics.java * Update Uri.java * Update RntbdClientChannelHealthChecker.java * Update RntbdToken.java * Update FaultInjectionRequestContext.java * Update RntbdTokenStream.java * Update RntbdTokenStream.java * Update RntbdTokenStream.java * EnumMap changes * Avoiding ImmutableEnumMaps * Fixing unit tests * Update ClientTelemetryMetrics.java * Update FaultInjectionRequestContext.java * Update CHANGELOG.md * Release preparations * Update CHANGELOG.md * Allowing to opt-out of E2E timeout for non-point operations via system property or environment variable (#38388) * Allowing to opt-out of E2E timeout for non-point operations via system property or environment variable * Tests * Reacting to code review feedback * remove winutils download steps (#38030) Co-authored-by: annie-mac <[email protected]> * addChannelAcquisitionContextInCosmosDiagnosticsBasedOnLatency (#38416) * add channelAcquisitionContext in cosmosDiagnostics when reaching threshold --------- Co-authored-by: annie-mac <[email protected]> * Fixing release break for hotfix * Update utils.py * Update set_versions.py --------- Co-authored-by: Annie Liang <[email protected]> Co-authored-by: annie-mac <[email protected]>
FabianMeiswinkel
added a commit
that referenced
this pull request
Feb 4, 2024
* Few minor diagnostics perf improvements (#38232) * Check for actual meterRegistry * Update ClientTelemetryMetrics.java * Update ClientTelemetryMetrics.java * Update CosmosDiagnosticsTest.java * Removing String.format in metrics * Update ClientTelemetryMetrics.java * Update Uri.java * Update RntbdClientChannelHealthChecker.java * Update RntbdToken.java * Update FaultInjectionRequestContext.java * Update RntbdTokenStream.java * Update RntbdTokenStream.java * Update RntbdTokenStream.java * EnumMap changes * Avoiding ImmutableEnumMaps * Fixing unit tests * Update ClientTelemetryMetrics.java * Update FaultInjectionRequestContext.java * Update CHANGELOG.md * Release preparations * Update CHANGELOG.md * Allowing to opt-out of E2E timeout for non-point operations via system property or environment variable (#38388) * Allowing to opt-out of E2E timeout for non-point operations via system property or environment variable * Tests * Reacting to code review feedback * remove winutils download steps (#38030) Co-authored-by: annie-mac <[email protected]> * addChannelAcquisitionContextInCosmosDiagnosticsBasedOnLatency (#38416) * add channelAcquisitionContext in cosmosDiagnostics when reaching threshold --------- Co-authored-by: annie-mac <[email protected]> * Fixing release break for hotfix * Update utils.py * Update set_versions.py * Update set_versions.py --------- Co-authored-by: Annie Liang <[email protected]> Co-authored-by: annie-mac <[email protected]>
FabianMeiswinkel
added a commit
that referenced
this pull request
Feb 4, 2024
* Few minor diagnostics perf improvements (#38232) * Check for actual meterRegistry * Update ClientTelemetryMetrics.java * Update ClientTelemetryMetrics.java * Update CosmosDiagnosticsTest.java * Removing String.format in metrics * Update ClientTelemetryMetrics.java * Update Uri.java * Update RntbdClientChannelHealthChecker.java * Update RntbdToken.java * Update FaultInjectionRequestContext.java * Update RntbdTokenStream.java * Update RntbdTokenStream.java * Update RntbdTokenStream.java * EnumMap changes * Avoiding ImmutableEnumMaps * Fixing unit tests * Update ClientTelemetryMetrics.java * Update FaultInjectionRequestContext.java * Update CHANGELOG.md * Release preparations * Update CHANGELOG.md * Allowing to opt-out of E2E timeout for non-point operations via system property or environment variable (#38388) * Allowing to opt-out of E2E timeout for non-point operations via system property or environment variable * Tests * Reacting to code review feedback * remove winutils download steps (#38030) Co-authored-by: annie-mac <[email protected]> * addChannelAcquisitionContextInCosmosDiagnosticsBasedOnLatency (#38416) * add channelAcquisitionContext in cosmosDiagnostics when reaching threshold --------- Co-authored-by: annie-mac <[email protected]> * Fixing release break for hotfix * Update utils.py * Update set_versions.py * Update set_versions.py * Update set_versions.py --------- Co-authored-by: Annie Liang <[email protected]> Co-authored-by: annie-mac <[email protected]>
FabianMeiswinkel
added a commit
that referenced
this pull request
Feb 4, 2024
…se (#38626) * Few minor diagnostics perf improvements (#38232) * Check for actual meterRegistry * Update ClientTelemetryMetrics.java * Update ClientTelemetryMetrics.java * Update CosmosDiagnosticsTest.java * Removing String.format in metrics * Update ClientTelemetryMetrics.java * Update Uri.java * Update RntbdClientChannelHealthChecker.java * Update RntbdToken.java * Update FaultInjectionRequestContext.java * Update RntbdTokenStream.java * Update RntbdTokenStream.java * Update RntbdTokenStream.java * EnumMap changes * Avoiding ImmutableEnumMaps * Fixing unit tests * Update ClientTelemetryMetrics.java * Update FaultInjectionRequestContext.java * Update CHANGELOG.md * Release preparations * Update CHANGELOG.md * Allowing to opt-out of E2E timeout for non-point operations via system property or environment variable (#38388) * Allowing to opt-out of E2E timeout for non-point operations via system property or environment variable * Tests * Reacting to code review feedback * remove winutils download steps (#38030) Co-authored-by: annie-mac <[email protected]> * addChannelAcquisitionContextInCosmosDiagnosticsBasedOnLatency (#38416) * add channelAcquisitionContext in cosmosDiagnostics when reaching threshold --------- Co-authored-by: annie-mac <[email protected]> * Fixing release break for hotfix * Update utils.py * Update set_versions.py * Update set_versions.py * Update set_versions.py * Update set_versions.py --------- Co-authored-by: Annie Liang <[email protected]> Co-authored-by: annie-mac <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
populating
ChannelAcquisitionTimelineinCosmosDiagnosticsbased on the duration spent inchannelAcquisitionStartedtimeline stage.By default if the
channelAcquisitionStartedtook more than 1s, then extra details will be populated inCosmosDiagnosticsin sectiontransportRequestChannelAcquisitionContextExamples:
