Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: DefaultAzureCredential/IntelliJCredential doesn't work even when the user is already signed in to Azure Plugin for IntelliJ. #37927

Closed

Conversation

wangmingliang-ms
Copy link

@wangmingliang-ms wangmingliang-ms commented Dec 5, 2023

Description

This PR fixes the problem that DefaultAzureCredential/IntelliJCredential doesn't work even when the user is already signed in to newer versions of the Azure Plugin for IntelliJ.
#35419, #27307, ...

Why it doesn't work with newer versions of Azure Plugin for IntelliJ

IntelliJCredential reads the AuthMethodDetails.json file generated by old versions of the Azure Plugin for IntelliJ. However, newer versions no longer generate this file.

Why this fix works

The newer versions of the Azure Plugin for IntelliJ implement authentication using azure-identity and recover the sign-in status across startups by leveraging the persistent token cache.
This fix tries to authenticate with the persisted token cache by the Azure Plugin for IntelliJ first and then uses authenticateWithIntelliJ (for backward compatibility).

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added Azure.Identity Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Dec 5, 2023
Copy link

github-actions bot commented Dec 5, 2023

Thank you for your contribution @wangmingliang-ms! We will review the pull request and get back to you soon.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Copy link

github-actions bot commented Feb 9, 2024

Hi @wangmingliang-ms. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label Feb 9, 2024
Copy link

Hi @wangmingliang-ms. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing /reopen if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.

@github-actions github-actions bot closed this Feb 16, 2024
@joshfree joshfree reopened this Feb 16, 2024
@github-actions github-actions bot removed the no-recent-activity There has been no recent activity on this issue. label Feb 16, 2024
@g2vinay
Copy link
Member

g2vinay commented Feb 16, 2024

Thank you for the contribution.
This issue was fixed as part of this PR previously: #35194
Closing this PR as discussed.

@g2vinay g2vinay closed this Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Identity Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
Development

Successfully merging this pull request may close these issues.

5 participants