Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle user thrown exceptions in PartitionProcessor. #36891

Merged
merged 8 commits into from
Sep 22, 2023

Conversation

conniey
Copy link
Member

@conniey conniey commented Sep 21, 2023

Description

Handles errors thrown from user code when PartitionProcessor.close or PartitionProcessor.processError is called. This ensures the clean-up method is called, and the partition can be claimed again.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Copy link
Member

@anuchandy anuchandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Connie!

@conniey conniey force-pushed the eventhubs/try-catch-processor branch from e5a496e to 1cd478a Compare September 22, 2023 19:49
@conniey conniey merged commit c2f6e5c into Azure:main Sep 22, 2023
@conniey conniey deleted the eventhubs/try-catch-processor branch September 22, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants