mgmt, migrate test-proxy #36079
Merged
mgmt, migrate test-proxy #36079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check API changes are not detected in this pull request. |
| String resourcePath = Paths.get(this.getClass().getResource("/session-records").toURI()).getParent().toString(); | ||
| String resourcePath = Paths.get(this.getClass().getResource("/junit-platform.properties").toURI()).getParent().toString(); |
There was a problem hiding this comment.
we don't have /session-records folder now.
| new TestProxySanitizer("$..primaryKey", null, REDACTED_VALUE, TestProxySanitizerType.BODY_KEY), | ||
| new TestProxySanitizer("$..secondaryKey", null, REDACTED_VALUE, TestProxySanitizerType.BODY_KEY), | ||
| // ContainerRegistry | ||
| new TestProxySanitizer("$..passwords[*].value", null, REDACTED_VALUE, TestProxySanitizerType.BODY_KEY) |
There was a problem hiding this comment.
for future tests in azure-resourcemanager and samples
weidongxu-microsoft
requested review from
haolingdong-msft,
XiaofeiCao and
ArthurMa1978
as code owners
XiaofeiCao
approved these changes
Jul 25, 2023
XiaofeiCao
reviewed
Jul 25, 2023
Comment on lines
28
to
33
| public RegistryTest() { | ||
| addSanitizers( | ||
| new TestProxySanitizer(String.format("$..%s", "uploadUrl"), null, REDACTED_VALUE, TestProxySanitizerType.BODY_KEY), | ||
| new TestProxySanitizer(String.format("$..%s", "logLink"), null, REDACTED_VALUE, TestProxySanitizerType.BODY_KEY) | ||
| new TestProxySanitizer("$..uploadUrl", null, REDACTED_VALUE, TestProxySanitizerType.BODY_KEY), | ||
| new TestProxySanitizer("$..logLink", null, REDACTED_VALUE, TestProxySanitizerType.BODY_KEY) | ||
| ); | ||
| } |
There was a problem hiding this comment.
Perhaps we can put them all under ResourceManagerTestProxyTestBase?
There was a problem hiding this comment.
This 2 is not unambiguously key name for secret. They could accidently match to other valid property in JSON. Hence I still put it in ACR instead of Base.
If we see more of them in other module, maybe we will, but with smaller scope e.g. $.logLink if it is directly under root of response JSON.
weidongxu-microsoft
added
Mgmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LIVE test "canCRUDSqlServerWithImportDatabase" in sql runs forever.
LIVE test "canCRUDEnterpriseTierDeployment" in appplatform fails with
"canCreateCustomDomainWithSsl" fails on another problem.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines