-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mgmt, compute migrate test-proxy #36069
mgmt, compute migrate test-proxy #36069
Conversation
for (KnownWindowsVirtualMachineImage image : Arrays.stream(KnownWindowsVirtualMachineImage.values()) | ||
.filter(image -> image != KnownWindowsVirtualMachineImage.WINDOWS_SERVER_2019_DATACENTER_WITH_CONTAINERS_GEN2 && image != KnownWindowsVirtualMachineImage.WINDOWS_SERVER_2019_DATACENTER_WITH_CONTAINERS) | ||
.collect(Collectors.toList())) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This 2 was deprecated in SDK. Now they are removed from CRP.
API change check API changes are not detected in this pull request. |
Why there are commits, e.g. service bus, traffic manager, since they are already merged in #36051? Changes in Compute part looks good to me. |
PR based on that branch (when it is not merged). I need these sanitizers (at least to avoid conflict). |
Got an error in only 1 test CI -- windows2022_18_False_False_surefiretest
https://dev.azure.com/azure-sdk/public/_build/results?buildId=2944422&view=logs&j=6c36ee5c-19e5-5fc6-8605-ce2015caa362&t=eb0f973f-965c-5ad5-b1c6-1a825007a4e1&l=723
Other test CIs is pass. Local run is pass.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines