Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgmt, compute migrate test-proxy #36069

Merged

Conversation

weidongxu-microsoft
Copy link
Member

@weidongxu-microsoft weidongxu-microsoft commented Jul 25, 2023

Start file scanning...
NumberOfAsset : 216
NumberOfAssetScanned : 144
NumberOfAssetBytes : 26,615,908
NumberOfAssetBytesScanned : 25,338,703
NumberOfScanResult: 0
NumberOfRankedResult : 0
NumberOfCredentialRecord: 0
NumberOfSuppressedRecord: 0
NumberOfScanError: 0

Got an error in only 1 test CI -- windows2022_18_False_False_surefiretest
https://dev.azure.com/azure-sdk/public/_build/results?buildId=2944422&view=logs&j=6c36ee5c-19e5-5fc6-8605-ce2015caa362&t=eb0f973f-965c-5ad5-b1c6-1a825007a4e1&l=723

Other test CIs is pass. Local run is pass.

[ERROR] com.azure.resourcemanager.compute.ManagedDiskOperationsTests.canCopyStartIncrementalSnapshot  Time elapsed: 14.089 s  <<< ERROR!
reactor.core.Exceptions$OverflowException: Could not emit tick 256 due to lack of requests (interval doesn't support small downstream requests that replenish slower than the ticks)
	at reactor.core.Exceptions.failWithOverflow(Exceptions.java:237)
	at reactor.core.publisher.FluxInterval$IntervalRunnable.run(FluxInterval.java:132)
	at reactor.core.scheduler.PeriodicWorkerTask.call(PeriodicWorkerTask.java:59)
	at reactor.core.scheduler.PeriodicWorkerTask.run(PeriodicWorkerTask.java:73)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:750)
	Suppressed: java.lang.Exception: #block terminated with an error
		at reactor.core.publisher.BlockingSingleSubscriber.blockingGet(BlockingSingleSubscriber.java:99)
		at reactor.core.publisher.Mono.block(Mono.java:1742)
		at com.azure.resourcemanager.compute.implementation.SnapshotImpl.awaitCopyStartCompletion(SnapshotImpl.java:124)
		at com.azure.resourcemanager.compute.ManagedDiskOperationsTests.canCopyStartIncrementalSnapshot(ManagedDiskOperationsTests.java:321)
		at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
		at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
		at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
		at java.lang.reflect.Method.invoke(Method.java:498)
		at org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:727)
		at org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60)
		at org.junit.jupiter.engine.execution.InvocationInterceptorChain$ValidatingInvocation.proceed(InvocationInterceptorChain.java:131)
		at org.junit.jupiter.api.AssertTimeoutPreemptively.lambda$submitTask$3(AssertTimeoutPreemptively.java:95)
		at java.util.concurrent.FutureTask.run(FutureTask.java:266)
		... 3 more

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Comment on lines +33 to +35
for (KnownWindowsVirtualMachineImage image : Arrays.stream(KnownWindowsVirtualMachineImage.values())
.filter(image -> image != KnownWindowsVirtualMachineImage.WINDOWS_SERVER_2019_DATACENTER_WITH_CONTAINERS_GEN2 && image != KnownWindowsVirtualMachineImage.WINDOWS_SERVER_2019_DATACENTER_WITH_CONTAINERS)
.collect(Collectors.toList())) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This 2 was deprecated in SDK. Now they are removed from CRP.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@weidongxu-microsoft weidongxu-microsoft marked this pull request as ready for review July 25, 2023 04:56
@XiaofeiCao
Copy link
Contributor

Why there are commits, e.g. service bus, traffic manager, since they are already merged in #36051?

Changes in Compute part looks good to me.

@weidongxu-microsoft
Copy link
Member Author

weidongxu-microsoft commented Jul 25, 2023

Why there are commits, e.g. service bus, traffic manager, since they are already merged in #36051?

Changes in Compute part looks good to me.

PR based on that branch (when it is not merged). I need these sanitizers (at least to avoid conflict).

@weidongxu-microsoft weidongxu-microsoft merged commit 68324d4 into Azure:main Jul 25, 2023
@weidongxu-microsoft weidongxu-microsoft deleted the mgmt_compute-test-proxy branch July 25, 2023 05:15
@weidongxu-microsoft weidongxu-microsoft added Mgmt This issue is related to a management-plane library. test-proxy Anything relating to test-proxy requests or issues. labels Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library. test-proxy Anything relating to test-proxy requests or issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants