Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgmt storage, test proxy migration #36055

Merged

Conversation

XiaofeiCao
Copy link
Contributor

@XiaofeiCao XiaofeiCao commented Jul 24, 2023

Description

migrate azure-resourcemanager-storage to test-proxy

Credscan result:

Start credential scanner
Initializing...
Initialization completed.
Start file scanning...
NumberOfAsset : 100
NumberOfAssetScanned : 30
NumberOfAssetBytes : 1,220,796
NumberOfAssetBytesScanned : 546,487
NumberOfScanResult: 0
NumberOfRankedResult : 0
NumberOfCredentialRecord: 0
NumberOfSuppressedRecord: 0
NumberOfScanError: 0

Though there are credentials found in StorageAccountOperationsTests:

"keys": [
  {
    "creationTime": "2023-07-24T14:14:30.8390062Z",
    "keyName": "key1",
    "value": "REDACTED",
    "permissions": "FULL"
  },
  {
    "creationTime": "2023-07-24T14:14:30.8390062Z",
    "keyName": "key2",
    "value": "REDACTED",
    "permissions": "FULL"
  }
]

Added sanitizer in ResourceManagerTestProxyTestBase as some other modules use storage as well.

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@XiaofeiCao XiaofeiCao marked this pull request as ready for review July 24, 2023 14:46
@XiaofeiCao XiaofeiCao added test-proxy Anything relating to test-proxy requests or issues. Mgmt This issue is related to a management-plane library. labels Jul 24, 2023
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library. test-proxy Anything relating to test-proxy requests or issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants