mgmt, authorization migrate test-proxy #36043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| protected AuthorizationManager authorizationManager; | ||
| protected ResourceManager resourceManager; | ||
|
|
||
| public GraphRbacManagementTest() { | ||
| addSanitizers( | ||
| new TestProxySanitizer(String.format("$..%s", "secretText"), null, REDACTED_VALUE, TestProxySanitizerType.BODY_KEY) |
There was a problem hiding this comment.
CredScan is not perfect. It didn't find this.
Moved to TestBase, as it is an important one. Some other module also uses msgraph.
|
API change check API changes are not detected in this pull request. |
weidongxu-microsoft
force-pushed
the
mgmt_authorization-test-proxy
branch
from
01c296c to
7289d72
Compare
weidongxu-microsoft
requested review from
haolingdong-msft,
XiaofeiCao and
ArthurMa1978
as code owners
XiaofeiCao
approved these changes
Jul 24, 2023
weidongxu-microsoft
added
Mgmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines