Update Web Pub Sub test recordings #35848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conniey
requested review from
joshfree,
srnagar,
anuchandy,
lmolkova and
JonathanGiles
as code owners
conniey
force-pushed
the
webpubsub/test-recordings
branch
from
e50722f to
1838458
Compare
|
API change check API changes are not detected in this pull request. |
conniey
force-pushed
the
webpubsub/test-recordings
branch
from
1838458 to
5ab572d
Compare
samvaity
reviewed
Jul 12, 2023
| @ParameterizedTest | ||
| @MethodSource("getTokenOptions") | ||
| @DoNotRecord |
There was a problem hiding this comment.
Yeah, The recording is always empty because no network calls are made when using a connection string. Seemed wasteful to have 7 recordings that are empty being uploaded. ;/
There was a problem hiding this comment.
If this class isn't recording anything we should make this a normal unit tests and remove the extends TestProxyTestBase.
There was a problem hiding this comment.
The other tests in this class do make network calls. :/
...-webpubsub/src/test/java/com/azure/messaging/webpubsub/WebPubSubServiceAsyncClientTests.java
Outdated
Show resolved
Hide resolved
...aging-webpubsub/src/test/java/com/azure/messaging/webpubsub/WebPubSubServiceClientTests.java
Show resolved
Hide resolved
conniey
force-pushed
the
webpubsub/test-recordings
branch
2 times, most recently
from
5a35b92 to
11195fb
Compare
conniey
force-pushed
the
webpubsub/test-recordings
branch
from
11195fb to
0127dd6
Compare
alzimmermsft
approved these changes
Jul 13, 2023
...-webpubsub/src/test/java/com/azure/messaging/webpubsub/WebPubSubServiceAsyncClientTests.java
Outdated
Show resolved
Hide resolved
...-webpubsub/src/test/java/com/azure/messaging/webpubsub/WebPubSubServiceAsyncClientTests.java
Show resolved
Hide resolved
...-webpubsub/src/test/java/com/azure/messaging/webpubsub/WebPubSubServiceAsyncClientTests.java
Show resolved
Hide resolved
conniey
force-pushed
the
webpubsub/test-recordings
branch
from
c1c0043 to
e7422a1
Compare
conniey
force-pushed
the
webpubsub/test-recordings
branch
from
e7422a1 to
f4d7487
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related: #33342
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines