Spring Snapshots #35726
Merged
Spring Snapshots #35726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrm9084
requested review from
backwind1233,
chenrujun,
hui1110,
Netyyyy,
saragluna,
stliu,
yiliuTo,
moarychan and
fangjian0423
as code owners
|
API change check API changes are not detected in this pull request. |
saragluna
requested changes
Aug 4, 2023
...appconfiguration/config/implementation/AppConfigurationApplicationSettingPropertySource.java
Outdated
Show resolved
Hide resolved
mssfang
reviewed
Aug 10, 2023
mssfang
reviewed
Aug 10, 2023
ivywei0125
reviewed
Aug 24, 2023
...appconfiguration/config/implementation/AppConfigurationApplicationSettingPropertySource.java
Outdated
Show resolved
Hide resolved
ivywei0125
reviewed
Aug 24, 2023
...appconfiguration/config/implementation/AppConfigurationApplicationSettingPropertySource.java
Outdated
Show resolved
Hide resolved
ivywei0125
reviewed
Aug 24, 2023
| store.getEndpoint(), client, selectedKeys.getKeyFilter(), | ||
| selectedKeys.getLabelFilter(profiles)); | ||
| store.getEndpoint(), client, | ||
| selectedKeys.getKeyFilter(), selectedKeys.getLabelFilter(profiles)); | ||
|
|
||
| propertySource.initProperties(); |
There was a problem hiding this comment.
Why there is no need to pass store.trim() for feature flags? Is it becasuse the trim is not available for feature flags?
There was a problem hiding this comment.
The prefix on feature flags is predetermined. i.e. it is always .appconfig.featureflag/ as defined by our design. I believe that this is consistent across all of our libraries.
saragluna
requested changes
Aug 29, 2023
...zure/spring/cloud/appconfiguration/config/implementation/AppConfigurationPropertySource.java
Outdated
Show resolved
Hide resolved
...zure/spring/cloud/appconfiguration/config/implementation/AppConfigurationPropertySource.java
Outdated
Show resolved
Hide resolved
...zure/spring/cloud/appconfiguration/config/implementation/AppConfigurationPropertySource.java
Outdated
Show resolved
Hide resolved
...zure/spring/cloud/appconfiguration/config/implementation/AppConfigurationPropertySource.java
Outdated
Show resolved
Hide resolved
...zure/spring/cloud/appconfiguration/config/implementation/AppConfigurationPropertySource.java
Outdated
Show resolved
Hide resolved
ivywei0125
reviewed
Aug 31, 2023
...zure/spring/cloud/appconfiguration/config/implementation/AppConfigurationPropertySource.java
Outdated
Show resolved
Hide resolved
ivywei0125
reviewed
Aug 31, 2023
saragluna
requested changes
Sep 7, 2023
...appconfiguration/config/implementation/AppConfigurationApplicationSettingPropertySource.java
Outdated
Show resolved
Hide resolved
...zure/spring/cloud/appconfiguration/config/implementation/AppConfigurationPropertySource.java
Show resolved
Hide resolved
...appconfiguration/config/implementation/AppConfigurationApplicationSettingPropertySource.java
Show resolved
Hide resolved
...appconfiguration/config/implementation/AppConfigurationApplicationSettingPropertySource.java
Show resolved
Hide resolved
...appconfiguration/config/implementation/AppConfigurationApplicationSettingPropertySource.java
Outdated
Show resolved
Hide resolved
Comment on lines
92
to
97
| } else if (setting instanceof FeatureFlagConfigurationSetting | ||
| && FEATURE_FLAG_CONTENT_TYPE.equals(setting.getContentType())) { | ||
| handleFeatureFlag(key, (FeatureFlagConfigurationSetting) setting, trimStrings); | ||
| } else if (StringUtils.hasText(setting.getContentType()) | ||
| && JsonConfigurationParser.isJsonContentType(setting.getContentType())) { | ||
| handleJson(setting, trimStrings); |
There was a problem hiding this comment.
Why does this trimSettings need to pass down to these two ifs?
There was a problem hiding this comment.
So, it needs to be passed down in both as both by default call the json code. The json code needs it as we allow for trimming of prefixes from the fully formed JSON key name.
...appconfiguration/config/implementation/AppConfigurationApplicationSettingPropertySource.java
Outdated
Show resolved
Hide resolved
...appconfiguration/config/implementation/AppConfigurationApplicationSettingPropertySource.java
Outdated
Show resolved
Hide resolved
...ing/cloud/appconfiguration/config/implementation/AppConfigurationSnapshotPropertySource.java
Outdated
Show resolved
Hide resolved
...va/com/azure/spring/cloud/appconfiguration/config/implementation/properties/ConfigStore.java
Outdated
Show resolved
Hide resolved
saragluna
requested changes
Sep 8, 2023
...zure/spring/cloud/appconfiguration/config/implementation/AppConfigurationPropertySource.java
Outdated
Show resolved
Hide resolved
saragluna
approved these changes
Sep 9, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds App Configuration Snapshots to Spring provider