[Communication - Job] Migrate to Test proxy #35688
Conversation
samvaity
commented
Jun 30, 2023
•
samvaity
commented
- Update for upsert operations to expect status codes {200, 201} - confirmed by @cparisineti (To be updated in swagger, follow up issue - [Communication - Job] Worker Thread not receiving job offers #35706)
- Disabled unassignJob test - Follow up issue - [Communication - Job] Worker Thread not receiving job offers #35706
|
API change check API changes are not detected in this pull request. |
|
Test proxy seems to be failing the tests. Is this a mandatory migration? Please link me a doc related to this in Java. I can look into what's causing the test failures. Thanks. |
| @@ -69,7 +69,7 @@ public final class JobRouterAdministrationsImpl { | |||
| @ServiceInterface(name = "AzureCommunicationSe") | |||
| public interface JobRouterAdministrationsService { | |||
| @Patch("/routing/classificationPolicies/{id}") | |||
| @ExpectedResponses({200}) | |||
| @ExpectedResponses({200,201}) | |||
There was a problem hiding this comment.
@cparisineti/williamzhao87 Is this expected?
Seeing this error even with the old testing framework.
Where 201 is an unexpected error. com.azure.communication.jobrouter.implementation.models.CommunicationErrorResponseException: Status code 201, "{"id":"JAVA_LIVE_TES..
There was a problem hiding this comment.
I see both 200, 201 in the service code - https://skype.visualstudio.com/SCC/_git/ic3_spool_ccaap?path=/src/Router.Api/V2022_07_18_preview/Controllers/ClassificationPoliciesController.cs&version=GBmaster&line=67&lineEnd=69&lineStartColumn=1&lineEndColumn=1&lineStyle=plain&_a=contents
but the swagger indeed only shows only 200 - https://github.com/Azure/azure-rest-api-specs/blob/main/specification/communication/data-plane/JobRouter/preview/2022-07-18-preview/communicationservicejobrouter.json#L43-L55
Test Proxy is just a testing framework update. It should not be interfering with the actual test cases. |
samvaity
force-pushed
the
communication-job
branch
from
6f9037b to
6b2844a
Compare
