Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates/Removes recordings to use Proxy #35544

Merged
merged 6 commits into from
Jun 20, 2023
Merged

Updates/Removes recordings to use Proxy #35544

merged 6 commits into from
Jun 20, 2023

Conversation

conniey
Copy link
Member

@conniey conniey commented Jun 20, 2023

Description

Updates tests to use test proxy. Removeso old tests.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@conniey conniey self-assigned this Jun 20, 2023
@conniey
Copy link
Member Author

conniey commented Jun 20, 2023

/azp run java - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

samvaity
samvaity approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@samvaity samvaity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm! 🎉

.../messaging/servicebus/administration/ServiceBusAdministrationAsyncClientIntegrationTest.java Outdated Show resolved Hide resolved
@samvaity samvaity mentioned this pull request Jun 20, 2023
Closed
@conniey
Copy link
Member Author

conniey commented Jun 20, 2023

/azp run java - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@conniey conniey merged commit cf5c9fa into Azure:main Jun 20, 2023
@conniey conniey deleted the servicebus-tests-newrecordings branch June 20, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samvaity samvaity samvaity approved these changes

@anuchandy anuchandy Awaiting requested review from anuchandy anuchandy is a code owner

@lmolkova lmolkova Awaiting requested review from lmolkova lmolkova is a code owner

Assignees

@conniey conniey

Labels
Service Bus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@conniey @azure-sdk @samvaity