Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Javadocs for Event Hubs #35284

Merged
merged 17 commits into from
Jun 20, 2023
Merged

Update Javadocs for Event Hubs #35284

merged 17 commits into from
Jun 20, 2023

Conversation

conniey
Copy link
Member

@conniey conniey commented Jun 2, 2023 •
edited
Loading

Description

  • Adds more documentation to Event Hubs
  • Cleans up samples that still use connections string and replace with DefaultAzureCredential
  • Consolidate code snippets and remove ReadmeSamples.java

Probably easier to digest by looking at the generated javadocs:
azure-messaging-eventhubs-javadocs.zip

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@conniey conniey self-assigned this Jun 2, 2023
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

anuchandy
anuchandy approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member

@anuchandy anuchandy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks!

@g2vinay g2vinay mentioned this pull request Jun 14, 2023
Open
@conniey conniey enabled auto-merge (squash) June 20, 2023 22:52
@conniey conniey merged commit 335b6ed into Azure:main Jun 20, 2023
@conniey conniey deleted the eventhubs/javadocs-update branch June 20, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g2vinay g2vinay g2vinay left review comments

@anuchandy anuchandy anuchandy approved these changes

@lmolkova lmolkova lmolkova approved these changes

Assignees

@conniey conniey

Labels
Event Hubs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@conniey @azure-sdk @anuchandy @lmolkova @g2vinay