Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly set Index and Search Analyzer names in FieldBuilder #35222

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Properly set Index and Search Analyzer names in FieldBuilder #35222

merged 1 commit into from
Jun 5, 2023

Conversation

alzimmermsft
Copy link
Member

Description

Fixes #35165

Fixes FieldBuilder to properly set indexAnalyzerName and searchAnalyzerName when SearchableField has indexAnalyzerName and searchAnalyzerName configured in the annotation.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@alzimmermsft alzimmermsft added Search Client This issue points to a problem in the data-plane of the library. labels May 31, 2023
@alzimmermsft alzimmermsft requested a review from jairmyree as a code owner May 31, 2023 13:48
@alzimmermsft alzimmermsft self-assigned this May 31, 2023
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

jairmyree
jairmyree approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@jairmyree jairmyree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alzimmermsft alzimmermsft merged commit 786f264 into Azure:main Jun 5, 2023
@alzimmermsft alzimmermsft deleted the AzSearch_FixFieldBuilderAnalyzerNames branch June 5, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jairmyree jairmyree jairmyree approved these changes

Assignees

@alzimmermsft alzimmermsft

Labels
Client This issue points to a problem in the data-plane of the library. Search
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SearchAnalyzer and IndexAnalyzer are overriden?
3 participants
@alzimmermsft @azure-sdk @jairmyree