Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyvault Secrets] Migrate recordings to asset repo #35181

Merged
merged 2 commits into from
May 30, 2023
Merged

[Keyvault Secrets] Migrate recordings to asset repo #35181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12afdc8
migrate recordings, initial push
samvaity May 26, 2023
7881b93
add changelog
samvaity May 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions eng/versioning/version_client.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,6 +425,7 @@ com.azure.tools:azure-sdk-build-tool;1.0.0-beta.1;1.0.0-beta.2
unreleased_com.azure:azure-core;1.40.0-beta.1
unreleased_com.azure:azure-core-tracing-opentelemetry;1.0.0-beta.36
unreleased_com.azure:azure-core-experimental;1.0.0-beta.40
unreleased_com.azure:azure-core-test;1.18.0-beta.1

# Released Beta dependencies: Copy the entry from above, prepend "beta_", remove the current
# version and set the version to the released beta. Released beta dependencies are only valid
Expand Down
1 change: 1 addition & 0 deletions sdk/keyvault/azure-security-keyvault-secrets/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
### Bugs Fixed

### Other Changes
- Migrate test recordings to assets repo.

## 4.6.2 (2023-05-23)

Expand Down
6 changes: 6 additions & 0 deletions sdk/keyvault/azure-security-keyvault-secrets/assets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"AssetsRepo": "Azure/azure-sdk-assets",
"AssetsRepoPrefixPath": "java",
"TagPrefix": "java/keyvault/azure-security-keyvault-secrets",
"Tag": "java/keyvault/azure-security-keyvault-secrets_66f694112f"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we generate this tag procedurally? Will this need to ever be updated in the future?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, we would need to update this tag when we want to update the recordings on the assets repo.
test-proxy push command is used to push these recordings to the azure-sdk-assets repo.
More details here -
https://github.com/Azure/azure-sdk-for-java/wiki/Test-Proxy-Migration#running-tests-in-record-mode

}
4 changes: 2 additions & 2 deletions sdk/keyvault/azure-security-keyvault-secrets/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
<dependency>
<groupId>com.azure</groupId>
<artifactId>azure-core</artifactId>
<version>1.39.0</version> <!-- {x-version-update;com.azure:azure-core;dependency} -->
<version>1.40.0-beta.1</version> <!-- {x-version-update;unreleased_com.azure:azure-core;dependency} -->
</dependency>

<dependency>
Expand Down Expand Up @@ -110,7 +110,7 @@
<dependency>
<groupId>com.azure</groupId>
<artifactId>azure-core-test</artifactId>
<version>1.17.0</version> <!-- {x-version-update;com.azure:azure-core-test;dependency} -->
<version>1.18.0-beta.1</version> <!-- {x-version-update;unreleased_com.azure:azure-core-test;dependency} -->
<scope>test</scope>
</dependency>

Expand Down
73 changes: 0 additions & 73 deletions ...ets/src/test/resources/session-records/SecretAsyncClientTest.backupSecretNotFound[1].json
View file
Open in desktop

This file was deleted.

117 changes: 0 additions & 117 deletions ...ult-secrets/src/test/resources/session-records/SecretAsyncClientTest.backupSecret[1].json
View file
Open in desktop

This file was deleted.

73 changes: 0 additions & 73 deletions ...ets/src/test/resources/session-records/SecretAsyncClientTest.deleteSecretNotFound[1].json
View file
Open in desktop

This file was deleted.

Loading