Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FaultInjection]FixConnectionCloseErrorNotAppliedWhenEndpointNotConfigured #35034

Merged

Conversation

xinlian12
Copy link
Member

Issue:
when injecting connection close/reset errors, if the faultInjectionEndpoint is not being configured, then the rule does not inject properly.

@xinlian12
Copy link
Member Author

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xinlian12
Copy link
Member Author

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@xinlian12
Copy link
Member Author

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@xinlian12
Copy link
Member Author

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@xinlian12
Copy link
Member Author

Test following test locally and passed:
readAllItemsWithDetailMetricsWithExplicitPageSize

The other failed test is known flaky test: conflictCustomLWW

@xinlian12
Copy link
Member Author

/check-enforcer override

1 similar comment
@xinlian12
Copy link
Member Author

/check-enforcer override

@xinlian12 xinlian12 merged commit 857e94f into Azure:main Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants