Use Test Proxy in azure-storage-queue #34494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alzimmermsft
added
Storage
|
API change check API changes are not detected in this pull request. |
alzimmermsft
requested review from
ibrahimrabab and
jaschrep-msft
as code owners
|
/azp run java - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - storage - tests |
1 similar comment
|
/azp run java - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
samvaity
reviewed
Apr 18, 2023
| import static org.junit.jupiter.api.Assertions.assertTrue; | ||
|
|
||
| public class BuildHelperTests { | ||
| private static final ClientLogger LOGGER = new ClientLogger(BuilderHelper.class); |
| @@ -0,0 +1,4 @@ | |||
| { | |||
There was a problem hiding this comment.
Should these be marked @DoNotRecord?
There was a problem hiding this comment.
I'm going to leave that for now as this is just a one-to-one port
ibrahimrabab
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates
azure-storage-queueto use Test Proxy instead of the in-processPlaybackHttpClient. As part of this changeazure-storage-queuewas moved from using Groovy/Spock for testing to JUnit 5.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines