-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Key Vault test proxy migration #34321
Conversation
API change check API changes are not detected in this pull request. |
can you rebase this so you're not pulling in the change that's already in main? |
36fc8ee
to
48546db
Compare
0098cb2
to
178f8c2
Compare
# Conflicts: # sdk/keyvault/azure-security-keyvault-administration/pom.xml # sdk/keyvault/azure-security-keyvault-certificates/pom.xml # sdk/keyvault/azure-security-keyvault-certificates/src/test/java/com/azure/security/keyvault/certificates/CertificateAsyncClientTest.java # sdk/keyvault/azure-security-keyvault-certificates/src/test/resources/session-records/CertificateAsyncClientTest.cancelCertificateOperation[1].json # sdk/keyvault/azure-security-keyvault-certificates/src/test/resources/session-records/CertificateClientTest.cancelCertificateOperation[1].json # sdk/keyvault/azure-security-keyvault-keys/pom.xml # sdk/keyvault/azure-security-keyvault-secrets/pom.xml
...rc/test/java/com/azure/security/keyvault/secrets/KeyVaultSecretsUserAgentPropertiesTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
...st/java/com/azure/security/keyvault/administration/KeyVaultAdministrationClientTestBase.java
Show resolved
Hide resolved
...icates/src/test/java/com/azure/security/keyvault/certificates/CertificateClientTestBase.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other changes, lgtm!
No description provided.