Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key Vault test proxy migration #34321

Merged
merged 24 commits into from
Apr 20, 2023
Merged

Conversation

vcolin7
Copy link
Member

@vcolin7 vcolin7 commented Apr 4, 2023

No description provided.

@vcolin7 vcolin7 added KeyVault Client This issue points to a problem in the data-plane of the library. test-enhancement labels Apr 4, 2023
@vcolin7 vcolin7 self-assigned this Apr 4, 2023
@ghost ghost added the Azure.Core azure-core label Apr 4, 2023
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@billwert
Copy link
Contributor

billwert commented Apr 4, 2023

can you rebase this so you're not pulling in the change that's already in main?

@vcolin7 vcolin7 requested a review from JimSuplizio as a code owner April 5, 2023 18:07
@vcolin7 vcolin7 force-pushed the kv-test-proxy-migration branch from 36fc8ee to 48546db Compare April 5, 2023 23:17
@vcolin7 vcolin7 force-pushed the kv-test-proxy-migration branch from 0098cb2 to 178f8c2 Compare April 6, 2023 00:53
vcolin7 added 3 commits April 11, 2023 18:17
# Conflicts:
#	sdk/keyvault/azure-security-keyvault-administration/pom.xml
#	sdk/keyvault/azure-security-keyvault-certificates/pom.xml
#	sdk/keyvault/azure-security-keyvault-certificates/src/test/java/com/azure/security/keyvault/certificates/CertificateAsyncClientTest.java
#	sdk/keyvault/azure-security-keyvault-certificates/src/test/resources/session-records/CertificateAsyncClientTest.cancelCertificateOperation[1].json
#	sdk/keyvault/azure-security-keyvault-certificates/src/test/resources/session-records/CertificateClientTest.cancelCertificateOperation[1].json
#	sdk/keyvault/azure-security-keyvault-keys/pom.xml
#	sdk/keyvault/azure-security-keyvault-secrets/pom.xml
Copy link
Contributor

@billwert billwert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Member

@samvaity samvaity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other changes, lgtm!

@vcolin7 vcolin7 merged commit 12c1488 into Azure:main Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core azure-core Client This issue points to a problem in the data-plane of the library. KeyVault test-enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants