Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tables Test Proxy Migration #34233

Merged
merged 14 commits into from
Apr 17, 2023
Merged

Tables Test Proxy Migration #34233

merged 14 commits into from
Apr 17, 2023

Conversation

jairmyree
Copy link
Member

Tables Test Proxy Migration (In development)

@jairmyree jairmyree mentioned this pull request Mar 28, 2023
Closed
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@jairmyree jairmyree assigned billwert and samvaity and unassigned billwert and samvaity Mar 28, 2023
@jairmyree jairmyree requested review from samvaity and billwert March 28, 2023 19:30
@jairmyree
Copy link
Member Author

I'm currently running into an issue where tests involving authenticating via a client secret credentials in RECORD mode do not work. A 404 (empty body) exception gets thrown from the service (Storage). The tests work fine in live mode.

The affected tests are:

Test Class Test Name
TableClientTest createTableWithMultipleTenants
TableServiceClientTest serviceCreateTableWithMultipleTenants
TableAsyncClientTest createTableWithMultipleTenants
TableServiceAsyncClientTest serviceCreateTableWithMultipleTenants

I'm marked the above tests to only run when LIVE for now while I'm awaiting assistance on this issue.

@jairmyree
Copy link
Member Author

I've also encountered that some tests are not able to find their recordings.

@jairmyree jairmyree force-pushed the jairmyree/tables-test-migration branch 4 times, most recently from b7115bf to bcc59a3 Compare April 10, 2023 21:56
@samvaity
Copy link
Member

I'm currently running into an issue where tests involving authenticating via a client secret credentials in RECORD mode do not work. A 404 (empty body) exception gets thrown from the service (Storage). The tests work fine in live mode.

The affected tests are:

Test Class Test Name
TableClientTest createTableWithMultipleTenants
TableServiceClientTest serviceCreateTableWithMultipleTenants
TableAsyncClientTest createTableWithMultipleTenants
TableServiceAsyncClientTest serviceCreateTableWithMultipleTenants
I'm marked the above tests to only run when LIVE for now while I'm awaiting assistance on this issue.

These should be resolved with latest released azure-core-test.

@jairmyree jairmyree force-pushed the jairmyree/tables-test-migration branch from eb27bf3 to b2239e7 Compare April 17, 2023 19:37
@jairmyree jairmyree marked this pull request as ready for review April 17, 2023 19:52
@jairmyree jairmyree requested a review from vcolin7 as a code owner April 17, 2023 19:52
@jairmyree jairmyree requested a review from samvaity April 17, 2023 19:52
@jairmyree jairmyree merged commit 9bf2fc7 into main Apr 17, 2023
@jairmyree jairmyree deleted the jairmyree/tables-test-migration branch April 17, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samvaity samvaity samvaity approved these changes

@billwert billwert Awaiting requested review from billwert

@vcolin7 vcolin7 Awaiting requested review from vcolin7 vcolin7 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jairmyree @azure-sdk @samvaity @billwert