Set service version query param for polling strategies #34216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srnagar
requested review from
alzimmermsft,
anuchandy,
lmolkova,
vcolin7,
mssfang,
JonathanGiles and
billwert
as code owners
ghost
added
the
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
alzimmermsft
approved these changes
Mar 27, 2023
sdk/core/azure-core/src/main/java/com/azure/core/util/polling/DefaultPollingStrategy.java
Outdated
Show resolved
Hide resolved
...e/azure-core/src/main/java/com/azure/core/util/polling/OperationResourcePollingStrategy.java
Outdated
Show resolved
Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/util/polling/LocationPollingStrategy.java
Outdated
Show resolved
Hide resolved
...ure-core/src/main/java/com/azure/core/util/polling/SyncOperationResourcePollingStrategy.java
Show resolved
Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/util/polling/DefaultPollingStrategy.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32483
This PR adds a new constructor overload to polling strategies to support setting the service version. Client libraries can now create polling strategies using the service version used to build the client. When a service version is set, all polling requests and getting the final result of a polling operation will use this service version. If the service response has an operation location URL that includes the service version, this version will be replaced by the version set by the client.