Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate Cognitive Search Code Generation in CI #33961

Merged

Conversation

alzimmermsft
Copy link
Member

Description

Adds an Update-Codegeneration.ps1 script into the Swagger folder for azure-search-documents which will cause CI to validate that code generation is up-to-date for the SDK.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@alzimmermsft alzimmermsft added Search EngSys This issue is impacting the engineering system. Client This issue points to a problem in the data-plane of the library. labels Mar 10, 2023
@alzimmermsft alzimmermsft requested a review from hallipr as a code owner March 10, 2023 14:36
@alzimmermsft alzimmermsft self-assigned this Mar 10, 2023
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Comment on lines +1 to +2
& (Join-Path $PSScriptRoot ".." ".." ".." ".." eng scripts Invoke-Codegeneration.ps1) -Directory $PSScriptRoot -AutorestOptions '--tag=package-2021-04-30-Preview-searchindex'
& (Join-Path $PSScriptRoot ".." ".." ".." ".." eng scripts Invoke-Codegeneration.ps1) -Directory $PSScriptRoot -AutorestOptions '--tag=package-2021-04-30-Preview-searchservice'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
& (Join-Path $PSScriptRoot ".." ".." ".." ".." eng scripts Invoke-Codegeneration.ps1) -Directory $PSScriptRoot -AutorestOptions '--tag=package-2021-04-30-Preview-searchindex'
& (Join-Path $PSScriptRoot ".." ".." ".." ".." eng scripts Invoke-Codegeneration.ps1) -Directory $PSScriptRoot -AutorestOptions '--tag=package-2021-04-30-Preview-searchservice'
$gitRoot = git rev-parse --show-toplevel
& (Join-Path $PSScriptRoot $gitRoot eng scripts Invoke-Codegeneration.ps1) -Directory $PSScriptRoot -AutorestOptions '--tag=package-2021-04-30-Preview-searchindex'
& (Join-Path $PSScriptRoot $gitRoot eng scripts Invoke-Codegeneration.ps1) -Directory $PSScriptRoot -AutorestOptions '--tag=package-2021-04-30-Preview-searchservice'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to save this change for a later date, mainly due to the need to know what git rev-parse --show-toplevel does compared to direct path hierarchy traversal (..)

@alzimmermsft alzimmermsft merged commit aa14214 into Azure:main Mar 13, 2023
@alzimmermsft alzimmermsft deleted the AzSearch_ValidateCodeGenerationInCi branch March 13, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system. Search
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants