Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Cognitive Search Javadocs in the Latest JDK Versions #33960

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Fix Cognitive Search Javadocs in the Latest JDK Versions #33960

merged 1 commit into from
Mar 13, 2023

Conversation

alzimmermsft
Copy link
Member

Description

Adds missing Javadoc descriptions and type parameters to resolve Javadoc generation issues found in the latest JDK versions.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@alzimmermsft alzimmermsft added Search Client This issue points to a problem in the data-plane of the library. Java Source Code Rules labels Mar 10, 2023
@alzimmermsft alzimmermsft self-assigned this Mar 10, 2023
@alzimmermsft alzimmermsft requested a review from jairmyree as a code owner March 10, 2023 14:24
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-search-documents

@alzimmermsft alzimmermsft mentioned this pull request Mar 10, 2023
Closed
jairmyree
jairmyree approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@jairmyree jairmyree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alzimmermsft alzimmermsft merged commit a078753 into Azure:main Mar 13, 2023
@alzimmermsft alzimmermsft deleted the AzSearch_FixJavadocsForLatestJavaVersions branch March 13, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jairmyree jairmyree jairmyree approved these changes

Assignees

@alzimmermsft alzimmermsft

Labels
Client This issue points to a problem in the data-plane of the library. Java Source Code Rules Search
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alzimmermsft @azure-sdk @jairmyree