Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Cognitive Search to Test Proxy #33952

Merged
merged 10 commits into from
Apr 11, 2023
Merged

Migrate Cognitive Search to Test Proxy #33952

merged 10 commits into from
Apr 11, 2023

Conversation

alzimmermsft
Copy link
Member

Description

Migrates azure-search-documents from the in-process PlaybackClient for CI and local testing to using the out-of-process Test Proxy developed by our engineering system.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@alzimmermsft alzimmermsft added Search Client This issue points to a problem in the data-plane of the library. labels Mar 9, 2023
@alzimmermsft alzimmermsft self-assigned this Mar 9, 2023
@alzimmermsft alzimmermsft mentioned this pull request Mar 9, 2023
Closed
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

billwert
billwert approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@billwert billwert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple notes but lgtm!

@alzimmermsft alzimmermsft merged commit 6953909 into Azure:main Apr 11, 2023
@alzimmermsft alzimmermsft deleted the AzSearch_MigrateToTestProxy branch April 11, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billwert billwert billwert approved these changes

@samvaity samvaity Awaiting requested review from samvaity

@jairmyree jairmyree Awaiting requested review from jairmyree jairmyree is a code owner

Assignees

@alzimmermsft alzimmermsft

Labels
Client This issue points to a problem in the data-plane of the library. Search
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alzimmermsft @azure-sdk @billwert