[TestProxyMigration-TA] Rerecord all tests #33931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mssfang
added
Client
|
API change check API changes are not detected in this pull request. |
mssfang
changed the title
Use the latest changes from unreleased azure-core-test
add unrelease tag in versioning file
mssfang
requested review from
alzimmermsft,
g2vinay and
JimSuplizio
as code owners
samvaity
reviewed
Apr 11, 2023
| @@ -1,47 +0,0 @@ | |||
| { | |||
There was a problem hiding this comment.
Were some of the tests not replaced but only removed?
There was a problem hiding this comment.
these are disabled tests record files
samvaity
reviewed
Apr 11, 2023
...on-records/TextAnalyticsAsyncClientTest.analyzePiiEntityRecognitionWithDomainFilters[1].json
Show resolved
Hide resolved
samvaity
reviewed
Apr 11, 2023
samvaity
approved these changes
Apr 11, 2023
| .clientId(clientId) | ||
| .tenantId(tenantId) | ||
| .build(); | ||
| credential = new DefaultAzureCredentialBuilder().build(); |
There was a problem hiding this comment.
nit: The configuration loading before this call is now ignored and can be removed
| if (interceptorManager.isPlaybackMode()) { | ||
| // since running in playback mode won't have the token credential, so skipping matching it. | ||
| interceptorManager.addMatchers(Arrays.asList( | ||
| new CustomMatcher().setExcludedHeaders(Arrays.asList("Authorization")))); |
There was a problem hiding this comment.
nit: Authorization header should be redacted by default and this isn't needed
There was a problem hiding this comment.
I think in this case we wanted to set this as with Record we expect the header to be present but with playback we don't set any auth mode at all so are missing even the presence of the header.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rerecord all tests in live mode with the new TestProxy.
(Phase 1) Steps to integrate with Test Proxy:
Use azure-core-test newer than 1.15.0. (If there are bug fixes you need you may need to depend on an unreleased version of the lib.)
Change the Base type of the respective SDK test class from TestBase to TestProxyTestBase
Run tests in record mode.
Validate recordings are as expected and do not contain secrets. Example updated recording
Check in the updated recordings to the main repo
Validate changes by running the Live/ci test pipeline