Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating spring data cosmos from sdk/cosmos to sdk/spring #33905

Merged
merged 26 commits into from
May 9, 2023

Conversation

trande4884
Copy link
Member

@trande4884 trande4884 commented Mar 7, 2023

Description

We are migrating azure-spring-data-cosmos and azure-spring-data-cosmos-test from sdk/cosmos to sdk/spring.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added Cosmos azure-spring All azure-spring related issues labels Mar 7, 2023
@chenrujun
Copy link

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@chenrujun
Copy link

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

@chenrujun chenrujun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update ci.yml and test.yml related contents.

image

@trande4884
Copy link
Member Author

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@trande4884
Copy link
Member Author

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@trande4884
Copy link
Member Author

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@trande4884
Copy link
Member Author

/check-enforcer override

@trande4884 trande4884 enabled auto-merge (squash) April 11, 2023 17:35
@trande4884 trande4884 disabled auto-merge April 13, 2023 01:56
@benbp
Copy link
Member

benbp commented Apr 13, 2023

Pipeline/test/matrix configs all looking good to me.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@trande4884
Copy link
Member Author

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@trande4884 trande4884 enabled auto-merge (squash) May 9, 2023 04:51
@trande4884
Copy link
Member Author

/check-enforcer override

@trande4884 trande4884 merged commit 47c6278 into Azure:main May 9, 2023
saragluna pushed a commit to saragluna/azure-sdk-for-java that referenced this pull request May 10, 2023
* Moving the azure-spring-data-cosmos and azure-spring-data-cosmos-test directories from sdk/cosmos to sdk/spring

* Updating the azure-spring-data-cosmos-test pom file.

* Updating the azure-spring-data-cosmos pom file.

* Updating the changelog.

* Making changes for PR.

* Making changes for PR.

* Update cspell to ignore these directories still.

* Fixing paths to sdk/spring from sdk/cosmos.

* Fixing more paths.

* Fixing more paths.

* Switching azure-spring-data-cosmos to use the dependency versoin of azure-cosmos and not the current version.

* Fixing dependency.

* Moving azure-spring-data-cosmos to the sdk/spring ci.

* Updating CI pipelines to run correctly for the migration. 'java - cosmos - ci' had spring removed from it and put in it's own pipeline to accomdate the change, this new pipeline is 'java - cosmos - spring -ci'

* Fixing tests.

* Removing un-used dependency.

* Resolving issue from merge conflict.

* Fixing spring integration tests

* Fixing spring integration tests.

* Removing duplicate from POM.
saragluna added a commit that referenced this pull request May 10, 2023
…34874)

* Migrating spring data cosmos from sdk/cosmos to sdk/spring (#33905)
---------

Co-authored-by: Trevor Anderson <[email protected]>
jairmyree pushed a commit to jairmyree/azure-sdk-for-java that referenced this pull request May 15, 2023
* Moving the azure-spring-data-cosmos and azure-spring-data-cosmos-test directories from sdk/cosmos to sdk/spring

* Updating the azure-spring-data-cosmos-test pom file.

* Updating the azure-spring-data-cosmos pom file.

* Updating the changelog.

* Making changes for PR.

* Making changes for PR.

* Update cspell to ignore these directories still.

* Fixing paths to sdk/spring from sdk/cosmos.

* Fixing more paths.

* Fixing more paths.

* Switching azure-spring-data-cosmos to use the dependency versoin of azure-cosmos and not the current version.

* Fixing dependency.

* Moving azure-spring-data-cosmos to the sdk/spring ci.

* Updating CI pipelines to run correctly for the migration. 'java - cosmos - ci' had spring removed from it and put in it's own pipeline to accomdate the change, this new pipeline is 'java - cosmos - spring -ci'

* Fixing tests.

* Removing un-used dependency.

* Resolving issue from merge conflict.

* Fixing spring integration tests

* Fixing spring integration tests.

* Removing duplicate from POM.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-spring All azure-spring related issues Cosmos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants