Cleanup Swagger Transforms and Customizations in Metrics Advisor #33874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
srnagar
reviewed
Mar 9, 2023
...e-ai-metricsadvisor/src/main/java/com/azure/ai/metricsadvisor/MetricsAdvisorAsyncClient.java
Show resolved
Hide resolved
Comment on lines
+751
to
+755
| DataFeedIngestionStatus dataFeedIngestionStatus = new DataFeedIngestionStatus(); | ||
| DataFeedIngestionStatusHelper.setMessage(dataFeedIngestionStatus, ingestionStatus.getMessage()); | ||
| DataFeedIngestionStatusHelper.setIngestionStatusType(dataFeedIngestionStatus, IngestionStatusType.fromString(toStringOrNull(ingestionStatus.getStatus()))); | ||
| DataFeedIngestionStatusHelper.setTimestamp(dataFeedIngestionStatus, ingestionStatus.getTimestamp()); | ||
| return dataFeedIngestionStatus; |
There was a problem hiding this comment.
Is this needed? The DataFeedIngestionStatus should be correctly serialized and we don't need accessors to make it public. What's the difference between the DataFeedIngestionStatus in implementation package and the one in public package?
There was a problem hiding this comment.
I think the issue is we need the DataFeedIngestionStatus in admin.models and not models. I believe earlier it was manually moved. But to make the swagger work as is without manual modifications we needed this transform.
are there any other options we can do?
srnagar
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure Metrics advisor swagger is updated with the public rest-api specs and also removes outdated customizations that are not applicable anymore.;