Removed delay in creating a new session receive link #33856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… new session receive link
ki1729
requested review from
anuchandy,
conniey,
liukun-msft and
ZejiaJiang
as code owners
|
API change check API changes are not detected in this pull request. |
anuchandy
approved these changes
Mar 8, 2023
| } else if (failure instanceof AmqpException | ||
| && ((AmqpException) failure).getErrorCondition() == AmqpErrorCondition.TIMEOUT_ERROR) { | ||
| return Mono.delay(SLEEP_DURATION_ON_ACCEPT_SESSION_EXCEPTION); | ||
| return Mono.empty(); // Retry always |
There was a problem hiding this comment.
Per discussion offline with Kishore, when this timeout error happens, it's already the case that there is a backoff completed - Either as a try-timeout on the client or as a delay waiting for service to respond.
Additionally (as mentioned in the pr description) this aligns with what T1 is doing code and git-ticket
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing fixed delay in retrys after timeout exceptions when creating a new session receive link.
This was fixed in track 1 SDK, but wasn't reflected here. Track 1 issue - Azure/azure-service-bus-java#394
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices