Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App Configuration Spring Feature Management Usage #33854

Merged
merged 15 commits into from
Mar 14, 2023
Merged

App Configuration Spring Feature Management Usage #33854

merged 15 commits into from
Mar 14, 2023

Conversation

mrm9084
Copy link
Member

@mrm9084 mrm9084 commented Mar 3, 2023

Description

  • Adds Usage Info for feature flags
  • Fixes a refresh bug with feature flags when using multiple labels.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

saragluna
saragluna requested changes Mar 6, 2023
View reviewed changes
...nfig/src/main/java/com/azure/spring/cloud/config/implementation/http/policy/TracingInfo.java Outdated Show resolved Hide resolved
...nfig/src/main/java/com/azure/spring/cloud/config/implementation/http/policy/TracingInfo.java Outdated Show resolved Hide resolved
...nfig/src/main/java/com/azure/spring/cloud/config/implementation/http/policy/TracingInfo.java Outdated Show resolved Hide resolved
...nfig/src/main/java/com/azure/spring/cloud/config/implementation/http/policy/TracingInfo.java Outdated Show resolved Hide resolved
...c/main/java/com/azure/spring/cloud/config/implementation/http/policy/FeatureFlagTracing.java Outdated Show resolved Hide resolved
...rc/main/java/com/azure/spring/cloud/config/implementation/AppConfigurationReplicaClient.java Outdated Show resolved Hide resolved
@saragluna
Copy link
Member

@chenrujun please take a look at this PR.

mrm9084 and others added 5 commits March 7, 2023 09:57
@mrm9084 @saragluna
Update sdk/spring/spring-cloud-azure-appconfiguration-config/src/main…
ab76aa2 
…/java/com/azure/spring/cloud/config/implementation/http/policy/TracingInfo.java

Co-authored-by: Xiaolu Dai <[email protected]>
@mrm9084 @saragluna
Update sdk/spring/spring-cloud-azure-appconfiguration-config/src/main…
84f7476 
…/java/com/azure/spring/cloud/config/implementation/http/policy/TracingInfo.java

Co-authored-by: Xiaolu Dai <[email protected]>
@mrm9084 @saragluna
Update sdk/spring/spring-cloud-azure-appconfiguration-config/src/main…
342ff07 
…/java/com/azure/spring/cloud/config/implementation/http/policy/TracingInfo.java

Co-authored-by: Xiaolu Dai <[email protected]>
@mrm9084 @saragluna
Update sdk/spring/spring-cloud-azure-appconfiguration-config/src/main…
c83d94c 
…/java/com/azure/spring/cloud/config/implementation/AppConfigurationReplicaClient.java

Co-authored-by: Xiaolu Dai <[email protected]>
@mrm9084
Code Review comments
afaf075
chenrujun
chenrujun reviewed Mar 8, 2023
View reviewed changes
...ig/src/main/java/com/azure/spring/cloud/config/implementation/AppConfigurationConstants.java Outdated Show resolved Hide resolved
...zure/spring/cloud/config/implementation/AppConfigurationFeatureManagementPropertySource.java Show resolved Hide resolved
...zure/spring/cloud/config/implementation/AppConfigurationFeatureManagementPropertySource.java Outdated Show resolved Hide resolved
...java/com/azure/spring/cloud/config/implementation/AppConfigurationPropertySourceLocator.java Show resolved Hide resolved
.../src/main/java/com/azure/spring/cloud/config/implementation/AppConfigurationRefreshUtil.java Outdated Show resolved Hide resolved
...c/main/java/com/azure/spring/cloud/config/implementation/http/policy/FeatureFlagTracing.java Show resolved Hide resolved
...nfig/src/main/java/com/azure/spring/cloud/config/implementation/http/policy/TracingInfo.java Outdated Show resolved Hide resolved
...nfig/src/main/java/com/azure/spring/cloud/config/implementation/http/policy/TracingInfo.java Outdated Show resolved Hide resolved
...nfig/src/main/java/com/azure/spring/cloud/config/implementation/http/policy/TracingInfo.java Outdated Show resolved Hide resolved
...nfig/src/main/java/com/azure/spring/cloud/config/implementation/http/policy/TracingInfo.java Outdated Show resolved Hide resolved
chenrujun
chenrujun approved these changes Mar 14, 2023
View reviewed changes
Copy link

@chenrujun chenrujun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chenrujun chenrujun added bug This issue requires a change to an existing behavior in the product in order to be resolved. feature-request This issue requires a new behavior in the product in order be resolved. azure-spring All azure-spring related issues azure-spring-app-configuration Spring app configuration related issues. labels Mar 14, 2023
@mrm9084 mrm9084 merged commit 388b720 into Azure:main Mar 14, 2023
@mrm9084 mrm9084 deleted the FeatureUsage branch March 14, 2023 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saragluna saragluna saragluna approved these changes

@chenrujun chenrujun chenrujun approved these changes

@backwind1233 backwind1233 Awaiting requested review from backwind1233

@hui1110 hui1110 Awaiting requested review from hui1110

@Netyyyy Netyyyy Awaiting requested review from Netyyyy Netyyyy is a code owner

@stliu stliu Awaiting requested review from stliu

@yiliuTo yiliuTo Awaiting requested review from yiliuTo

@moarychan moarychan Awaiting requested review from moarychan moarychan is a code owner

@fangjian0423 fangjian0423 Awaiting requested review from fangjian0423

Assignees

@mrm9084 mrm9084

Labels
azure-spring All azure-spring related issues azure-spring-app-configuration Spring app configuration related issues. bug This issue requires a change to an existing behavior in the product in order to be resolved. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
Spring Cloud Azure
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrm9084 @azure-sdk @saragluna @chenrujun