Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check for AbsoluteUri from startRecording #33850

Merged
merged 4 commits into from
Mar 30, 2023

Conversation

fhaghbin-msft
Copy link
Member

@fhaghbin-msft fhaghbin-msft commented Mar 3, 2023

Description

Removing the check for absoluteUri for recording state callback uri since this check is being done on backend

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@cochi2 cochi2 enabled auto-merge (squash) March 29, 2023 23:58
auto-merge was automatically disabled March 29, 2023 23:59

Head branch was pushed to by a user without write access

@cochi2 cochi2 enabled auto-merge (squash) March 30, 2023 00:03
@cochi2 cochi2 merged commit 0fa61e1 into Azure:main Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants