Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callautomation/speech #33735

Merged
merged 4 commits into from
Feb 24, 2023
Merged

Callautomation/speech #33735

merged 4 commits into from
Feb 24, 2023

Conversation

wangrui-msft
Copy link
Member

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added the Communication label Feb 24, 2023
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-communication-callautomation

@@ -266,7 +266,6 @@ Mono<Response<TransferCallResult>> transferToParticipantCallWithResponseInternal

TransferToParticipantRequestInternal request = new TransferToParticipantRequestInternal()
.setTargetParticipant(CommunicationIdentifierConverter.convert(transferToParticipantCallOptions.getTargetCallInvite().getTarget()))
.setTransfereeCallerId(PhoneNumberIdentifierConverter.convert(transferToParticipantCallOptions.getTargetCallInvite().getSourceCallIdNumber()))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wangrui-msft , Can you please check if this is intended?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, confirmed with the SDK team, they removed it in swagger, and .net SDK also has this change merged.

@wangrui-msft wangrui-msft merged commit 71759bc into main Feb 24, 2023
@wangrui-msft wangrui-msft deleted the callautomation/speech branch February 24, 2023 19:44
mssfang pushed a commit to mssfang/azure-sdk-for-java that referenced this pull request Apr 18, 2023
* Add new reason code

* Add speechlanguage to recognize option

* fix string empty check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants