Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On branch edburns-msft-eb-3250-reference-other-archetype-repo #33619

Conversation

edburns
Copy link
Member

@edburns edburns commented Feb 21, 2023

Goal: reduce the chances that others will have the same confusion.
Implementation: cross-links in the README.md files. From azure-sdk-archetype to azure-maven-archetypes and vice versa.
Assigned To: Ed Burns

@JonathanGiles wrote:

it's a fine thing to do

modified:   sdk/tools/azure-sdk-archetype/README.md

Signed-off-by: Ed Burns <[email protected]>
modified:   sdk/tools/azure-sdk-archetype/README.md

Signed-off-by: Ed Burns <[email protected]>
@edburns edburns enabled auto-merge (squash) February 21, 2023 02:47
@edburns edburns self-assigned this Feb 21, 2023
Comment on lines +12 to +14
> **Note**
> All other Microsoft maintained Azure maven archetypes can be found at [https://github.com/microsoft/azure-maven-archetypes](https://github.com/microsoft/azure-maven-archetypes).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me - any thoughts @srnagar?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me too.

Comment on lines +12 to +14
> **Note**
> All other Microsoft maintained Azure maven archetypes can be found at [https://github.com/microsoft/azure-maven-archetypes](https://github.com/microsoft/azure-maven-archetypes).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me too.

@edburns edburns merged commit eb6ca45 into Azure:main Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants