[Phase-1] Disposition handling in Amqp-Core (and fixes a thread-hang edege-case in Service Bus disposition) #33593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuchandy
added
Event Hubs
Service Bus
Azure.Core
|
API change check API changes are not detected in this pull request. |
anuchandy
commented
Feb 17, 2023
...qp/src/main/java/com/azure/core/amqp/implementation/handler/ReceiverUnsettledDeliveries.java
Show resolved
Hide resolved
...qp/src/main/java/com/azure/core/amqp/implementation/handler/ReceiverUnsettledDeliveries.java
Show resolved
Hide resolved
anuchandy
requested review from
alzimmermsft,
samvaity,
g2vinay,
JimSuplizio,
mssfang,
JonathanGiles,
ki1729,
conniey,
liukun-msft,
ZejiaJiang,
srnagar,
haolingdong-msft and
weidongxu-microsoft
as code owners
liukun-msft
approved these changes
Feb 21, 2023
...qp/src/main/java/com/azure/core/amqp/implementation/handler/ReceiverUnsettledDeliveries.java
Show resolved
Hide resolved
...qp/src/main/java/com/azure/core/amqp/implementation/handler/ReceiverUnsettledDeliveries.java
Show resolved
Hide resolved
...qp/src/main/java/com/azure/core/amqp/implementation/handler/ReceiverUnsettledDeliveries.java
Outdated
Show resolved
Hide resolved
...qp/src/main/java/com/azure/core/amqp/implementation/handler/ReceiverUnsettledDeliveries.java
Outdated
Show resolved
Hide resolved
...qp/src/main/java/com/azure/core/amqp/implementation/handler/ReceiverUnsettledDeliveries.java
Outdated
Show resolved
Hide resolved
… code review feedback
liukun-msft
reviewed
Feb 22, 2023
...qp/src/main/java/com/azure/core/amqp/implementation/handler/ReceiverUnsettledDeliveries.java
Outdated
Show resolved
Hide resolved
…ositionWorksOnClose'
anuchandy
changed the title
anuchandy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disposition is a generic AMQP concept available in brokers that support receive-link with unsettled settlement mode. This two-phased initiative aims to expose disposition API in AMQP core ReceiveLinkHandler and ReactorReciver types. This PR is phase-1, where we add ReceiverUnsettledDeliveries implementation type in AMQP-Core. See the work item #33651