Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Event Hub live test breaks #33559

Closed
wants to merge 12 commits into from
Closed

Conversation

conniey
Copy link
Member

@conniey conniey commented Feb 17, 2023

Description

Fixes integration test failures and adds some documentation to where constants are location.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@conniey
Copy link
Member Author

conniey commented Feb 17, 2023

/azp run java - eventhubs - tests

@conniey conniey self-assigned this Feb 17, 2023
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@conniey
Copy link
Member Author

conniey commented Feb 18, 2023

/azp run java - eventhubs - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@conniey
Copy link
Member Author

conniey commented Feb 18, 2023

/azp run java - eventhubs - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@conniey
Copy link
Member Author

conniey commented Feb 19, 2023

/azp run java - eventhubs - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@conniey
Copy link
Member Author

conniey commented Feb 20, 2023

/azp run java - eventhubs - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@conniey
Copy link
Member Author

conniey commented Feb 21, 2023

/azp run java - eventhubs - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

return span;
if (ERROR_STATUS_MESSAGE.equals(statusMessage)) {
return span.setStatus(StatusCode.ERROR);
} else if (SUCCESS_STATUS_MESSAGE.equals(statusMessage)) {
Copy link
Member Author

@conniey conniey Feb 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lmolkova Can you double check this is what you intended? I noticed in EventHubsTracer that it was passing in "success" as the default value, which in the old code would be a StatusCode.Error. The javadocs for OpenTelemetryTracer.end didn't specify this case though, so I wasn't sure my fix is what you wanted.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really, I got rid of "success" altogether here #33600. along with other changes

Copy link
Member

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be covered in #33600 which should fix the tests and also add a few improvements, but I like the comments and clean-ups in this one.

UPDATE: I updated #33600 to incorporate changes and fixes from this PR and also returned back "success" for the time being. I hope to get your eyes on that PR and merge it to fix tests.

lmolkova added a commit to lmolkova/azure-sdk-for-java that referenced this pull request Feb 22, 2023
/**
* Unit tests for {@link OpenTelemetryUtils}.
*/
public class OpenTelemetryUtilsTests {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one is tested on OpenTelemetryTracerTests

@conniey conniey force-pushed the telemetry-test-fixes branch from 0fa8700 to 230f181 Compare February 23, 2023 21:05
@conniey
Copy link
Member Author

conniey commented Feb 23, 2023

Closed in favour of #33600

@conniey conniey closed this Feb 23, 2023
@conniey conniey deleted the telemetry-test-fixes branch February 23, 2023 21:46
lmolkova added a commit to lmolkova/azure-sdk-for-java that referenced this pull request Mar 1, 2023
lmolkova added a commit to lmolkova/azure-sdk-for-java that referenced this pull request Mar 2, 2023
lmolkova added a commit to lmolkova/azure-sdk-for-java that referenced this pull request Mar 7, 2023
lmolkova added a commit that referenced this pull request Mar 7, 2023
* Update tracing to new core changes
* incorporating improvements from #33559
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants