Clarify AAD properties for Spring Cloud Azure #33538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Netyyyy
changed the title
Netyyyy
requested review from
backwind1233,
chenrujun,
hui1110,
saragluna,
stliu,
yiliuTo,
moarychan and
fangjian0423
as code owners
stliu
reviewed
Feb 17, 2023
...in/java/com/azure/spring/cloud/autoconfigure/aad/properties/AadAuthenticationProperties.java
Show resolved
Hide resolved
stliu
reviewed
Feb 17, 2023
...e/src/main/java/com/azure/spring/cloud/autoconfigure/aadb2c/properties/AadB2cProperties.java
Show resolved
Hide resolved
|
API change check API changes are not detected in this pull request. |
chenrujun
reviewed
Feb 21, 2023
...in/java/com/azure/spring/cloud/autoconfigure/aad/properties/AadAuthenticationProperties.java
Outdated
Show resolved
Hide resolved
...in/java/com/azure/spring/cloud/autoconfigure/aad/properties/AadAuthenticationProperties.java
Show resolved
Hide resolved
...e/src/main/java/com/azure/spring/cloud/autoconfigure/aadb2c/properties/AadB2cProperties.java
Outdated
Show resolved
Hide resolved
moarychan
requested changes
Feb 22, 2023
...e/src/main/java/com/azure/spring/cloud/autoconfigure/aadb2c/properties/AadB2cProperties.java
Outdated
Show resolved
Hide resolved
moarychan
reviewed
Feb 22, 2023
...e/src/main/java/com/azure/spring/cloud/autoconfigure/aadb2c/properties/AadB2cProperties.java
Outdated
Show resolved
Hide resolved
chenrujun
reviewed
Feb 23, 2023
...in/java/com/azure/spring/cloud/autoconfigure/aad/properties/AadAuthenticationProperties.java
Show resolved
Hide resolved
...in/java/com/azure/spring/cloud/autoconfigure/aad/properties/AadAuthenticationProperties.java
Outdated
Show resolved
Hide resolved
...in/java/com/azure/spring/cloud/autoconfigure/aad/properties/AadAuthenticationProperties.java
Outdated
Show resolved
Hide resolved
saragluna
approved these changes
Feb 24, 2023
moarychan
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.
Fixes: #29578