Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppConfig 4.0 Updating Feature Management Version Schema #33531

Merged
merged 5 commits into from
Feb 16, 2023
Merged

AppConfig 4.0 Updating Feature Management Version Schema #33531

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d3ad1bf
Clearing up todos
mrm9084 Feb 15, 2023
eef0d48
Update ci.yml
mrm9084 Feb 16, 2023
fe930d5
Updating Change log
mrm9084 Feb 16, 2023
4566f93
udpate the changelogs
saragluna Feb 16, 2023
acdbcd7
fix spelling
saragluna Feb 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions sdk/spring/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,20 +548,20 @@ extends:
- name: spring-cloud-azure-appconfiguration-config
groupId: com.azure.spring
safeName: springcloudazureappconfigurationconfig
releaseInBatch: ${{ parameters.release_azurespringcloudappconfigurationconfig }}
releaseInBatch: ${{ parameters.release_springcloudazureappconfigurationconfig }}
- name: spring-cloud-azure-appconfiguration-config-web
groupId: com.azure.spring
safeName: springcloudazureappconfigurationconfigweb
releaseInBatch: ${{ parameters.release_azurespringcloudappconfigurationconfigweb }}
releaseInBatch: ${{ parameters.release_springcloudazureappconfigurationconfigweb }}
- name: spring-cloud-azure-feature-management
groupId: com.azure.spring
safeName: springcloudazurefeaturemanagement
releaseInBatch: ${{ parameters.release_azurespringcloudfeaturemanagement }}
releaseInBatch: ${{ parameters.release_springcloudazurefeaturemanagement }}
- name: spring-cloud-azure-feature-management-web
groupId: com.azure.spring
safeName: springcloudazurefeaturemanagementweb
releaseInBatch: ${{ parameters.release_azurespringcloudfeaturemanagementweb }}
releaseInBatch: ${{ parameters.release_springcloudazurefeaturemanagementweb }}
- name: spring-cloud-azure-starter-appconfiguration-config
groupId: com.azure.spring
safeName: springcloudazurestarterappconfigurationconfig
releaseInBatch: ${{ parameters.release_azurespringcloudstarterappconfigurationconfig }}
releaseInBatch: ${{ parameters.release_springcloudazurestarterappconfigurationconfig }}
2 changes: 1 addition & 1 deletion ...src/main/java/com/azure/spring/cloud/config/implementation/AppConfigurationConstants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public class AppConfigurationConstants {
/**
* Feature Management Key Prefix
*/
public static final String FEATURE_MANAGEMENT_KEY = "feature-management.featureManagement.";
public static final String FEATURE_MANAGEMENT_KEY = "feature-management.";

/**
* Feature Flag Prefix
Expand Down
2 changes: 1 addition & 1 deletion ...e/spring/cloud/config/implementation/AppConfigurationFeatureManagementPropertySource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ public void initProperties() {
featureConfigurationSettings.add(setting);
Object feature = createFeature((FeatureFlagConfigurationSetting) setting);

String configName = FEATURE_MANAGEMENT_KEY // TODO (mametcal) This is Wrong/Needs to be updated with Feature Management 4.0
String configName = FEATURE_MANAGEMENT_KEY
+ setting.getKey().trim().substring(FEATURE_FLAG_PREFIX.length());

properties.put(configName, feature);
Expand Down
7 changes: 0 additions & 7 deletions ...va/com/azure/spring/cloud/config/implementation/AppConfigurationReplicaClientFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,6 @@ public Map<String, ConnectionManager> getConnections() {
return CONNECTIONS;
}

/**
* @return the configStores
*/
List<ConfigStore> getConfigStores() { // TODO (mametcal) This is never used?
return configStores;
}

/**
* Returns the current used endpoint for a given config store.
* @param originEndpoint identifier of the store. The identifier is the primary endpoint of the store.
Expand Down