Offer option to perform async client operations with timeout #33298
+82
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #26465 (comment) for the details of the issue, in short we have been observing regularly that some threads in a concurrentConsumer setup would stop to process further messages. A threadump shows them hanging in the complete section. After forking the repository and doing a quick test this issue can indeed be resolved by performing the .complete() action with a timeout after which the thread would recover. This change is created in a non invasive manor that offers clients the option to call the method with a given timeout while not changing any current default behavior
TheDevOps
requested review from
anuchandy,
ki1729,
conniey,
liukun-msft and
ZejiaJiang
as code owners
ghost
added
Service Bus
customer-reported
|
Thank you for your contribution TheDevOps! We will review the pull request and get back to you soon. |
3 tasks
|
@microsoft-github-policy-service agree company="Porsche Informatik GmbH" |
|
See #33493 for details on why this is likely to have some side effects and only hides the root cause which will be addressed now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #26465 (comment) for the details of the issue in short we have been observing regularly that some threads in a concurrentConsumer setup would stop to process further messages. A threadump shows them hanging in the complete section. After forking the repository and doing a quick test this issue can indeed be resolved by performing the .complete() action with a timeout after which the thread would recover. This change is created in a non invasive manor that offers clients the option to call the method with a given timeout while not changing any current default behavior
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines