Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgmt redis, update to 2022-06 #33148

Merged
merged 5 commits into from
Jan 27, 2023
Merged

Conversation

XiaofeiCao
Copy link
Contributor

Description

Manual code on tests in eb91c93

  1. aof-backup-enabled moved from additionalProperties to root of RedisConfiguration.
  2. Added linked server removal after test.

live tests pass.

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jan 24, 2023

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-resourcemanager-redis

@XiaofeiCao XiaofeiCao marked this pull request as ready for review January 26, 2023 14:01
Copy link
Member

@weidongxu-microsoft weidongxu-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run "RedisConfigurationTests.generateConfigurationUtils" and update the code in ConfigurationUtils?

@XiaofeiCao
Copy link
Contributor Author

Did you run "RedisConfigurationTests.generateConfigurationUtils" and update the code in ConfigurationUtils?

Yeah, it passed.

I checked again and find out that aof-backup-enabled is a newly added property of RedisConfiguraion. I'll add a test case of aof-backup-enabled and add it to toMap in ConfigurationUtils.

@weidongxu-microsoft
Copy link
Member

weidongxu-microsoft commented Jan 27, 2023

Yeah, it passed.

I checked again and find out that aof-backup-enabled is a newly added property of RedisConfiguraion. I'll add a test case of aof-backup-enabled and add it to toMap in ConfigurationUtils.

I mean this is not actually a test. It outputs the code of ConfigurationUtils.java. You should be able to just paste the output and replace part of ConfigurationUtils.java <-- this replacement is still manual

@XiaofeiCao
Copy link
Contributor Author

I mean this is not actually a test. It outputs the code of ConfigurationUtils.java. You should be able to just paste the output and replace part of ConfigurationUtils.java <-- this replacement is still manual

OK, got it... Thanks!

@XiaofeiCao XiaofeiCao merged commit 62a479c into Azure:main Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants