-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mgmt redis, update to 2022-06 #33148
Conversation
API change check APIView has identified API level changes in this PR and created following API reviews. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you run "RedisConfigurationTests.generateConfigurationUtils" and update the code in ConfigurationUtils?
Yeah, it passed. I checked again and find out that |
I mean this is not actually a test. It outputs the code of ConfigurationUtils.java. You should be able to just paste the output and replace part of ConfigurationUtils.java <-- this replacement is still manual |
OK, got it... Thanks! |
Description
Manual code on tests in eb91c93
aof-backup-enabled
moved fromadditionalProperties
to root ofRedisConfiguration
.live tests pass.
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines