Use RevApi Code Extensions for Better Performance #33130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check API changes are not detected in this pull request. |
alzimmermsft
requested review from
samvaity,
g2vinay,
JonathanGiles,
backwind1233,
chenrujun,
hui1110,
Netyyyy,
saragluna,
stliu,
yiliuTo,
moarychan,
fangjian0423,
mssfang,
joshfree and
srnagar
as code owners
alzimmermsft
requested review from
anuchandy,
conniey and
lmolkova
as code owners
|
/check-enforcer evaluate |
6 tasks
joshfree
reviewed
Feb 8, 2023
| @@ -51,7 +51,7 @@ public TransformationResult tryTransform(@Nullable E oldElement, @Nullable E new | |||
| return TransformationResult.keep(); | |||
| } | |||
|
|
|||
| if (!CORE_ARCHIVE.matcher(newArchive).matches()) { | |||
| if (!newArchive.startsWith("com.azure:azure-core:")) { | |||
There was a problem hiding this comment.
nit: should strings like this be const values defined elsewhere.
There was a problem hiding this comment.
Since they're only used in one location they don't explicitly need to be as the compiler will change them to constants in the class file.
joshfree
approved these changes
Feb 8, 2023
|
/azp run java - resourcemanager |
|
/azp run java - spring |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
alzimmermsft
deleted the
AzEng_UseCustomTreeFilterInsteadOfConfigurationFilters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At this time, we have a centralized RevApi configuration for all SDKs and due to having a single configuration it has a very large set of filters and transforms. Each filter and transform adds a non-trivial amount of overhead when running RevApi analysis as these configurations are turned into code filters and transform, from my understanding, on a one-to-one bases of configuration entry to operation performed in a list, meaning that with each run time for RevApi linting effectively grows linearly.
This PR changes portions of our RevApi configuration to begin using RevApi extension code where many filters and transforms are compacted into a single operation. The first change is using a single custom
TreeFilterProviderto handle filtering out APIs from RevApi analysis. The change not only removes many filters that would have been created before it uses non-allocatingStringcomparisons instead of regexes, greatly reducing CPU usage and memory allocations.Reduces a RevApi only validation run in
code-quality-reportsfrom roughly 90-105 minutes to 30-35 minutes. Reduces Analyze stage of Spring pipelines from about 30 minutes to 15 minutes and Resource Manager pipelines from about 50 minutes to 25 minutes.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines