AppendBlobClient.getOutputStream(boolean) to overwrite correctly if set to true #33086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to appendBlobOutputStream
…to appendBlobOutputStream
…to appendBlobOutputStream
ibrahimrabab
requested review from
jaschrep-msft and
alzimmermsft
as code owners
ghost
added
the
|
/azp run java - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
...ge/azure-storage-blob/src/main/java/com/azure/storage/blob/specialized/AppendBlobClient.java
Outdated
Show resolved
Hide resolved
| public BlobOutputStream getBlobOutputStream(boolean overwrite) { | ||
| AppendBlobRequestConditions requestConditions = null; | ||
| if (!overwrite) { | ||
| if (exists()) { |
There was a problem hiding this comment.
Do we want to throw here or put the OutputStream into append mode?
There was a problem hiding this comment.
So it looks like in .NET when overwrite is false and blob exists, they continue to append. We should probably follow the same logic.
…/blob/specialized/AppendBlobClient.java Co-authored-by: Alan Zimmer <[email protected]>
…bab/azure-sdk-for-java into appendBlobOutputStream
|
/azp run java - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
alzimmermsft
approved these changes
Jan 19, 2023
...ge/azure-storage-blob/src/main/java/com/azure/storage/blob/specialized/AppendBlobClient.java
Show resolved
Hide resolved
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
|
/azp run java - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
alzimmermsft
approved these changes
Jan 19, 2023
|
/azp run java - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
xinlian12
pushed a commit
to xinlian12/azure-sdk-for-java
that referenced
this pull request
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
resolves #32602
When
AppendBlobClient.getOutputStream(true)is called, the existing blob is not overwritten. Instead, new data gets appended to the existing data.Changed javadoc for
AppendBlobClient.getOutputStream()that specifies new data will be appended to the existing blob (which is the actual correct behavior) instead of getting overwritten.Changed logic for
AppendBlobClient.getOutputStream(boolean)to create a new blob that will overwrite existing blob ifoverwrite=true.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines