[AppConfig] Not share SyncTokenPolicy across Configuration clients #33031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mssfang
added
Client
|
API change check API changes are not detected in this pull request. |
| @@ -186,7 +185,7 @@ public ConfigurationClientBuilder() { | |||
| * and {@link #retryPolicy(HttpPipelinePolicy)} have been set. | |||
| */ | |||
| public ConfigurationClient buildClient() { | |||
| return new ConfigurationClient(buildInnerClient(), DEFAULT_SYNC_TOKEN_POLICY); | |||
| return new ConfigurationClient(buildInnerClient(), new SyncTokenPolicy()); | |||
There was a problem hiding this comment.
Does the SyncTokenPolicy used in the pipeline and the one passed to the ConigurationClient need to be the same?
There was a problem hiding this comment.
SyncTokenPolicy needs to be the same object. Updated.
mrm9084
requested changes
Jan 17, 2023
...pconfiguration/src/main/java/com/azure/data/appconfiguration/ConfigurationClientBuilder.java
Outdated
Show resolved
Hide resolved
...pconfiguration/src/main/java/com/azure/data/appconfiguration/ConfigurationClientBuilder.java
Show resolved
Hide resolved
alzimmermsft
approved these changes
Jan 17, 2023
mrm9084
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SyncTokenPolicy should be exist as a single standalone object per Configuration client but not shared cross clients.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines