SB stress tests: instrument sender #32776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
requested review from
anuchandy,
ki1729,
conniey,
liukun-msft and
ZejiaJiang
as code owners
ghost
added
the
conniey
approved these changes
Jan 5, 2023
anuchandy
approved these changes
Jan 5, 2023
liukun-msft
reviewed
Jan 5, 2023
| @@ -19,7 +19,8 @@ spec: | |||
| source $ENV_FILE && | |||
| export CONTAINER_NAME=sender && | |||
| export APPLICATIONINSIGHTS_ROLE_NAME=sender && | |||
| java "org.springframework.boot.loader.JarLauncher" \ | |||
| java -javaagent:BOOT-INF/classes/applicationinsights-agent-3.4.1.jar \ | |||
There was a problem hiding this comment.
Oh, I haven't added the agent for sender because there is no custom telemtry data for sending scenario. But yes, we need to add this to send SDK telemtry. For EH stress test, the sender also need add agent if we want to track the sender client data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny fix that adds sender instrumentation and updates gitignore for generated files