Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update redis samples and documentation. #32769

Merged
merged 6 commits into from
Jan 5, 2023
Merged

Update redis samples and documentation. #32769

merged 6 commits into from
Jan 5, 2023

Conversation

conniey
Copy link
Member

@conniey conniey commented Jan 4, 2023

Description

Update redis samples and documentation.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@conniey conniey requested a review from anuchandy as a code owner January 4, 2023 17:47
@conniey conniey self-assigned this Jan 4, 2023
@ghost ghost added the Event Hubs label Jan 4, 2023
@azure-sdk
Copy link
Collaborator

azure-sdk commented Jan 4, 2023 •
edited
Loading

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-messaging-eventhubs-checkpointstore-blob
azure-messaging-eventhubs-checkpointstore-jedis

anuchandy
anuchandy approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@anuchandy anuchandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

...ava/com/azure/messaging/eventhubs/checkpointstore/jedis/JedisRedisCheckpointStoreSample.java Outdated Show resolved Hide resolved
@conniey conniey enabled auto-merge (squash) January 5, 2023 00:39
@conniey conniey merged commit cdd7dd7 into Azure:main Jan 5, 2023
@conniey conniey deleted the redis/update-documentation branch January 5, 2023 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ki1729 ki1729 ki1729 approved these changes

@anuchandy anuchandy anuchandy approved these changes

@liukun-msft liukun-msft Awaiting requested review from liukun-msft

@ZejiaJiang ZejiaJiang Awaiting requested review from ZejiaJiang

Assignees

@conniey conniey

Labels
Event Hubs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@conniey @azure-sdk @anuchandy @ki1729