mgmt, local codegen for recoveryservicessiterecovery #32748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XiaofeiCao
commented
Jan 3, 2023
| import com.azure.resourcemanager.recoveryservicessiterecovery.models.StorageClassificationMappingInput; | ||
|
|
||
| /** An instance of this class provides access to all the operations defined in StorageClassificationMappingsClient. */ | ||
| public interface StorageClassificationMappingsClient { |
There was a problem hiding this comment.
Renamed from ReplicationStorageClassificationMappingsClient to StorageClassificationMappingsClient.
There was a problem hiding this comment.
Is it done manually or in codegen?
There was a problem hiding this comment.
It's through local codegen.
autorest PR: Azure/autorest.java#1911
specs PR: Azure/azure-rest-api-specs#22040
XiaofeiCao
commented
Jan 3, 2023
| @JsonSubTypes.Type(name = "InMageRcm", value = InMageRcmUpdateApplianceForReplicationProtectedItemInput.class) | ||
| }) | ||
| @Immutable | ||
| public class UpdateReplicationProtectedItemProviderSpecificInput { |
There was a problem hiding this comment.
Renamed from UpdateApplianceForReplicationProtectedItemProviderSpecificInput to UpdateReplicationProtectedItemProviderSpecificInput.
XiaofeiCao
commented
Jan 3, 2023
| output_folder = OUTPUT_FOLDER_FORMAT.format(service), | ||
| output_folder = OUTPUT_FOLDER_FORMAT.format(service) |
There was a problem hiding this comment.
Trailing comma seems wrong.
XiaofeiCao
requested review from
hallipr,
JimSuplizio,
alzimmermsft,
samvaity,
g2vinay,
weidongxu-microsoft,
haolingdong-msft,
ArthurMa1978,
weshaggard,
benbp,
joshfree,
srnagar,
anuchandy,
conniey,
lmolkova and
JonathanGiles
as code owners
weidongxu-microsoft
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines