Removing inactive/timed out sessions #32365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conniey
requested review from
anuchandy,
ki1729,
srnagar,
JonathanGiles,
haolingdong-msft,
liukun-msft,
weidongxu-microsoft and
ZejiaJiang
as code owners
ghost
added
the
|
API change check API changes are not detected in this pull request. |
ki1729
approved these changes
Nov 29, 2022
liukun-msft
approved these changes
Nov 30, 2022
| @@ -8,6 +8,8 @@ | |||
|
|
|||
| ### Bugs Fixed | |||
|
|
|||
| - Removing inactive session when it has timed out, so `ReactorConnection.getSession(String)` does not return the same session. | |||
There was a problem hiding this comment.
Change Removing to Removed ?
If there is a related issue, we can also attach.
There was a problem hiding this comment.
Thanks for the catch. There was no GitHub issue associated with it. :( I should create one though so we can redirect people if they see the same issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the issue that if a timeout occurs waiting for a session to be active, the same session is returned when another call to
createSessionis made.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines