Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicit Text Support in Serialization #32277

Merged
merged 15 commits into from
Jan 10, 2023
Merged

Explicit Text Support in Serialization #32277

merged 15 commits into from
Jan 10, 2023

Conversation

alzimmermsft
Copy link
Member

@alzimmermsft alzimmermsft commented Nov 21, 2022 •
edited
Loading

Description

Fixes #8708

Adds explicit support for text in serialization. Introduces a new SerializationEncoding TEXT and adds a few Content-Types that map to it.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@alzimmermsft alzimmermsft self-assigned this Nov 21, 2022
@ghost ghost added the Azure.Core azure-core label Nov 21, 2022
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-core

@alzimmermsft alzimmermsft marked this pull request as ready for review January 6, 2023 17:01
@alzimmermsft alzimmermsft mentioned this pull request Jan 9, 2023
Closed
@alzimmermsft alzimmermsft requested a review from srnagar January 9, 2023 20:59
@alzimmermsft alzimmermsft dismissed srnagar’s stale review January 9, 2023 20:59

Requesting re-review due to changes

srnagar
srnagar approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@srnagar srnagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alzimmermsft alzimmermsft merged commit 54ff625 into Azure:main Jan 10, 2023
@alzimmermsft alzimmermsft deleted the AzCore_TextContentType branch January 10, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srnagar srnagar srnagar approved these changes

@anuchandy anuchandy Awaiting requested review from anuchandy anuchandy is a code owner

@lmolkova lmolkova Awaiting requested review from lmolkova lmolkova is a code owner

@vcolin7 vcolin7 Awaiting requested review from vcolin7 vcolin7 is a code owner

@mssfang mssfang Awaiting requested review from mssfang mssfang is a code owner

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles JonathanGiles is a code owner

@billwert billwert Awaiting requested review from billwert billwert is a code owner

@samvaity samvaity Awaiting requested review from samvaity

@g2vinay g2vinay Awaiting requested review from g2vinay

@JimSuplizio JimSuplizio Awaiting requested review from JimSuplizio

Assignees

@alzimmermsft alzimmermsft

Labels
Azure.Core azure-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Support for Additional Response Content-Types
3 participants
@alzimmermsft @azure-sdk @srnagar