ServiceBus tracing: fix current context when processing concurrent requests #31993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
requested review from
anuchandy,
ki1729,
conniey,
liukun-msft and
ZejiaJiang
as code owners
ghost
added
lmolkova
force-pushed
the
servicebus-leaking-context-fix
branch
from
82224df to
de2835b
Compare
|
API change check API changes are not detected in this pull request. |
ki1729
approved these changes
Nov 8, 2022
| @@ -518,33 +518,29 @@ public String getTo() { | |||
| } | |||
|
|
|||
| /** | |||
| * Adds a new key value pair to the existing context on Message. | |||
| * ASets context on the message. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When processing concurrently, process callback is scheduled and runs on a different thread than subscriber of FluxTrace, making scope disappear. This change fixes it for processor and also ensures that context does not leak for parallel receive.
It does not affect EventHubs.