Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move autorest client to java sdk central repo #3174

Merged
merged 4,612 commits into from
Mar 25, 2019
Merged

Move autorest client to java sdk central repo #3174

merged 4,612 commits into from
Mar 25, 2019

Conversation

sima-zhu
Copy link
Contributor

@sima-zhu sima-zhu commented Mar 22, 2019 •
edited by mssfang
Loading

There are basically three steps moving the common runtime package to central repo:

  1. First, move the entire package without changes.
  2. Then, we will cleanup the pom file, spotbugs and checkstyle.
  3. Last, we will run the live tests.

This commit is to finish the following first step.

issue: Move autorest client to java sdk central repo #3174

RikkiGibson and others added 30 commits October 30, 2017 12:47
@RikkiGibson
Fix type name comparison in credentials test
70c635f
@RikkiGibson
Merge pull request Azure#281 from RikkiGibson/MigratePom
057efef 
Migrate to v2 package and add v2 to groupId in POMs
@RikkiGibson
Make HTTP request mutable and add clone() method
90e8d44
@RikkiGibson
Use assertSame/assertNotSame for identity comparison
3c44704
@RikkiGibson
Fix broken links and HTML in Javadocs
3df0ce5
Add better error message when a polling strategy cannot be determined
08636bd
@RikkiGibson
Remove unnecessary comments
2edb8c4
@RikkiGibson
Merge pull request Azure#283 from RikkiGibson/FixJavadocs
a8f6239 
Fix broken links and HTML in Javadocs
@RikkiGibson
Convert String to byte[] with UTF-8 encoding
401828c
@RikkiGibson
Merge pull request Azure#286 from RikkiGibson/UseUTF8Encoding
74b018c 
Convert String to byte[] with UTF-8 encoding
@RikkiGibson
Merge pull request Azure#282 from RikkiGibson/MutableHttpRequest
2ba45c1 
Make HttpRequest mutable
@RikkiGibson
Merge pull request Azure#284 from Azure/ImproveErrorMessage
98ffdb7 
Add better error message when a polling strategy cannot be determined
Verify a response's status code before creating a polling strategy
3d1393a
@RikkiGibson
Rename addCustomPolicy to addRequestPolicy. Remove withMaxIdleConnect…
1e4f939 
…ions.
@RikkiGibson
Fix bugs and docs
56946cd
@RikkiGibson
Fix checkstyle
8fcebf0
Add status code checking to PollStrategy.updateFromAsync()
486f58c
Fix checkstyle
8d9f17a
@RikkiGibson
Merge pull request Azure#291 from Azure/CheckStatusCodeBeforePollingS…
1428e5c 
…trategy

Check status code before and during polling strategy
@RikkiGibson
Fix mentions of credentials in comments
1720394
Merge pull request Azure#290 from RikkiGibson/RenameRestClientMethods
8b52cf8 
Rename RestClient methods
@RikkiGibson
Add proxy support
1394167
@RikkiGibson
Ignore proxy tests
9d48071
@RikkiGibson
Add proxy authentication policy
650a6ac
@RikkiGibson
Add scheme to proxy authentication header value
9b7cf6a
@RikkiGibson
Fix checkstyle
0a5611f
@RikkiGibson
Add address information to IllegalArgumentException
c502ff5
@RikkiGibson
Add mention of proxy authentication in Builder.withProxy
aed2f18
@RikkiGibson
Fixes from review feedback
34f461b
@RikkiGibson
Rename URI in NettyAdapter to channelAddress
78f0f28
anuchandy and others added 4 commits March 13, 2019 18:30
@anuchandy
Adapting to new package structure. (Azure#586)
caa5840 
* Adapting to new package structure.

* using azure-common-parent parent artifactId, starting with version 1.0.0-SNAPSHOT
@anuchandy
upgrading jackson version to 2.9.4 (Azure#591)
16cad94
@sima-zhu
Add 'common/' from commit '16cad94c3f51f9e5df196b7b5c175e91400930bc'
d81be12 
Move autorest client runtime to sdk central repo

git-subtree-dir: common
git-subtree-mainline: 9dd4ba9
git-subtree-split: 16cad94
@sima-zhu
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-java …
7b66b13 
…into merge
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@sima-zhu sima-zhu requested a review from mssfang March 22, 2019 00:45
@sima-zhu sima-zhu self-assigned this Mar 22, 2019
@sima-zhu sima-zhu added the Client This issue points to a problem in the data-plane of the library. label Mar 22, 2019
@mssfang
Copy link
Member

mssfang commented Mar 22, 2019 •
edited
Loading

LGTM. Please add @JonathanGiles as reviewer as well.

@JonathanGiles
Copy link
Member

Sima, don't merge this - ask @weshaggard to do it so that the revision history is maintained.

@sima-zhu sima-zhu requested review from mssfang and weshaggard March 22, 2019 17:01
@weshaggard
Copy link
Member

@sima-zhu what is the issue tracking the remaining clean-up work? Your description says:

issue: Move autorest client to java sdk central repo #3174

but that is this PR not the an issue. I want to make some notes about some things that need to be cleaned up.

weshaggard
weshaggard reviewed Mar 25, 2019
View reviewed changes
common/versionConfig.csv
@@ -0,0 +1,5 @@
com.microsoft.azure.v3,autorest-clientruntime-for-java,2.0.0,2.0.1-SNAPSHOT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should understand if anything will be using this file and if not remove as part of clean-up.

weshaggard
weshaggard reviewed Mar 25, 2019
View reviewed changes
common/build-tools/src/main/resources/suppressions.xml
@@ -0,0 +1,39 @@
<?xml version="1.0"?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As part of the clean-up these should be moved the suppression files under the eng directory.

weshaggard
weshaggard reviewed Mar 25, 2019
View reviewed changes
common/build-tools/pom.xml
@@ -0,0 +1,48 @@
<!--
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This project should be removed during clean-up.

@sima-zhu
Copy link
Contributor Author

sima-zhu commented Mar 25, 2019 via email •
edited by weshaggard
Loading

weshaggard
weshaggard reviewed Mar 25, 2019
View reviewed changes
common/.gitignore
@@ -0,0 +1,31 @@
build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be removed during clean-up.

weshaggard
weshaggard reviewed Mar 25, 2019
View reviewed changes
common/.travis.yml
@@ -0,0 +1,17 @@
language: android
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be removed during clean-up.

weshaggard
weshaggard reviewed Mar 25, 2019
View reviewed changes
common/LICENSE
@@ -0,0 +1,21 @@
The MIT License (MIT)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be removed during clean-up.

weshaggard
weshaggard reviewed Mar 25, 2019
View reviewed changes
common/README.md
@@ -0,0 +1,124 @@
[![Build Status](https://travis-ci.org/Azure/autorest-clientruntime-for-java.svg?branch=v2)](https://travis-ci.org/Azure/autorest-clientruntime-for-java)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README.md files should go under the package folder during clean-up.

weshaggard
weshaggard reviewed Mar 25, 2019
View reviewed changes
common/azure-android-client-authentication/build.gradle
@@ -0,0 +1,117 @@
buildscript {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We aren't using gradle to build so we should convert to maven projects during the clean-up.

@weshaggard
Copy link
Member

I don’t have an issue tracking the remaining clean up work yet. Do we need to open an issue for the remaining clean up? I can do it right now.

Yes please file a follow-up issue in this repo to track the remaining work that needs to be done.

@weshaggard weshaggard merged commit 3daeede into Azure:master Mar 25, 2019
@sima-zhu
Copy link
Contributor Author

Issue tracking the remaining clean up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard left review comments

@mssfang mssfang mssfang approved these changes

@JonathanGiles JonathanGiles JonathanGiles approved these changes

Assignees

@sima-zhu sima-zhu

Labels
Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.