Upgrade the deprecated apis for spring cloud azure 5.0 #31543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sorClientBuilder.retry()
ghost
added
the
|
API change check APIView has identified API level changes in this PR and created following API reviews. spring-integration-azure-core |
…deprecated APIs, because there's no replacement available for the API 'com.nimbusds.jose.jwk.RSAKey.Builder.x509CertThumbprint'
moarychan
requested review from
hallipr,
JimSuplizio,
alzimmermsft,
samvaity,
g2vinay,
backwind1233,
chenrujun,
hui1110,
Netyyyy,
saragluna,
stliu,
yiliuTo and
fangjian0423
as code owners
moarychan
requested review from
JonathanGiles,
JamesBirdsall,
sjkwak,
JianpingChen,
ankitarorabit,
minnieliu,
a team,
anilba06,
gkostal,
LarryOsterman,
joshfree,
srnagar,
anuchandy,
conniey and
lmolkova
as code owners
moarychan
commented
Oct 26, 2022
| @@ -48,6 +48,8 @@ public class DefaultMessageHandler extends AbstractMessageProducingHandler { | |||
| private final String destination; | |||
| private final SendOperation sendOperation; | |||
| private boolean sync = false; | |||
|
|
|||
| @SuppressWarnings("deprecation") | |||
| private ListenableFutureCallback<Void> sendCallback; | |||
There was a problem hiding this comment.
We will refer to the ListenableFutureCallback usage from here https://github.com/spring-projects/spring-framework/blob/v6.0.0-RC2/spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/DeferredResultMethodReturnValueHandler.java#L79-L92
saragluna
approved these changes
Oct 26, 2022
...n/java/com/azure/spring/cloud/autoconfigure/aad/AadWebApplicationHttpSecurityConfigurer.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/azure/spring/cloud/autoconfigure/aad/implementation/jwt/AadJwtEncoder.java
Show resolved
Hide resolved
| @@ -39,7 +38,7 @@ public Resource retrieveResource(URL url) throws IOException { | |||
| HttpHeaders headers = new HttpHeaders(); | |||
| headers.setAccept(Arrays.asList(MediaType.APPLICATION_JSON, APPLICATION_JWK_SET_JSON)); | |||
| ResponseEntity<String> response = getResponse(url, headers); | |||
| if (response.getStatusCodeValue() != HttpStatus.OK.value()) { | |||
| if (response.getStatusCode().isError()) { | |||
|
Also fixed the issue #31716 in Spring Cloud Azure 5.x |
moarychan
deleted the
moary/replace-deprecated-apis-for-spring-cloud-azure
branch
saragluna
reviewed
Oct 28, 2022
...gure/src/main/java/com/azure/spring/cloud/autoconfigure/aad/filter/UserPrincipalManager.java
Show resolved
Hide resolved
fangjian0423
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31330
Upgrade the deprecated APIs of Spring and Azure SDKs.