Fix 252: Table: Need to support signing when URL contains escapable characters #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed catch statement to perform a reasonable fallback if the URLEncoder call fails. Added missing imports statements.
|
Added a unit test and addressed the review feedback. |
| service.deleteEntity(TEST_TABLE_2, result3.getEntity().getPartitionKey(), result3.getEntity().getRowKey()); | ||
| service.deleteEntity(TEST_TABLE_2, result4.getEntity().getPartitionKey(), result4.getEntity().getRowKey()); | ||
|
|
||
| // Assert |
There was a problem hiding this comment.
Do we need to assert the success of the deletion by validating the original entities do not exist any more?
There was a problem hiding this comment.
Good idea. I'll add that.
There was a problem hiding this comment.
See below for the new asserts
jcookems
added a commit
that referenced
this pull request
Apr 4, 2012
Fix 252: Table: Need to support signing when URL contains escapable characters
joostdenijs
pushed a commit
to joostdenijs/azure-sdk-for-java
that referenced
this pull request
Jan 18, 2013
implement the get version of MediaProcessorType
joostdenijs
pushed a commit
to joostdenijs/azure-sdk-for-java
that referenced
this pull request
Jan 18, 2013
Test fixes 527 544
joostdenijs
pushed a commit
to joostdenijs/azure-sdk-for-java
that referenced
this pull request
Jan 18, 2013
Remove wrapper code that corresponds to non-existant processors
jianghaolu
pushed a commit
to jianghaolu/azure-sdk-for-java
that referenced
this pull request
Apr 5, 2017
Fix 252: Table: Need to support signing when URL contains escapable characters
jianghaolu
pushed a commit
to jianghaolu/azure-sdk-for-java
that referenced
this pull request
Apr 5, 2017
Bettererror
g2vinay
pushed a commit
to g2vinay/azure-sdk-for-java
that referenced
this pull request
Feb 12, 2019
Re-release for corrupt signing
g2vinay
pushed a commit
to g2vinay/azure-sdk-for-java
that referenced
this pull request
Mar 4, 2019
Update version for release
g2vinay
pushed a commit
to g2vinay/azure-sdk-for-java
that referenced
this pull request
May 30, 2019
code changelog
samvaity
added a commit
to samvaity/azure-sdk-for-java
that referenced
this pull request
Dec 18, 2019
navalev
pushed a commit
to navalev/azure-sdk-for-java
that referenced
this pull request
Dec 24, 2019
Search documents
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.